New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 807455 link

Starred by 1 user
Status: Fixed
Owner:
█ thanhdle@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix unit test using timestamps expects a Pacific timezone

Project Member Reported by thanhdle@chromium.org, Jan 30 2018 
The test failed when run in different time zone since it is expecting PST.

Comment 1 by thanhdle@chromium.org, Jan 31 2018 

The test failed at InterventionsInternalsUITest.LogNewMessage because it is hard-coded to test the style of the time format.

https://cs.chromium.org/chromium/src/chrome/test/data/webui/interventions_internals_browsertest.js?q=interventions_internals+f:js&dr=C&l=196
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2b486936df0c8ada060af3fc83d371808e253e0

commit f2b486936df0c8ada060af3fc83d371808e253e0
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Jan 31 19:04:44 2018

Fix unit test checking only PST timezone.

Bug:  807455 
Change-Id: I8452ac767e9483b875397a29ae5c6c8a81debb6f
Reviewed-on: https://chromium-review.googlesource.com/895287
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533348}
[modify] https://crrev.com/f2b486936df0c8ada060af3fc83d371808e253e0/chrome/test/data/webui/interventions_internals_browsertest.js

Comment 3 by thanhdle@chromium.org, Jan 31 2018

Status: Fixed (was: Started)
►

Sign in to add a comment