New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807454 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 807430



Sign in to add a comment

Bluetooth service to observe powerd's SuspendImminent and suspend discovery

Project Member Reported by sonnysasaka@chromium.org, Jan 30 2018

Issue description

This is the first subtask of crbug.com/807430: Create a bluetooth daemon which listens to powerd's SuspendImminent and issue the discovery suspend request to bluez.
 
Blocking: 807430
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/6744b813f67dd7774446af34327353f6af41aeca

commit 6744b813f67dd7774446af34327353f6af41aeca
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Sat Feb 03 21:23:03 2018

bluetooth: Add bluez methods for pause/unpause discovery

BUG=b:70811583, chromium:807454 
TEST=none

Change-Id: I7ab8701804071916e26948ef9b0820a1aa280a75
Reviewed-on: https://chromium-review.googlesource.com/900207
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/6744b813f67dd7774446af34327353f6af41aeca/dbus/service_constants.h

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/367495175ada4bd65616acced0f143015304dac8

commit 367495175ada4bd65616acced0f143015304dac8
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Wed Feb 07 05:32:43 2018

bluetooth: Bluetooth service for Chrome OS initial commit.

This CL lays out the initial skeleton of the new Chrome OS bluetooth
service, and additionally contains a relay service between power manager
and bluez about suspend events. The bluetooth daemon listens to power
manager SuspendImminent signal, then requests bluez to suspend discovery
and after it finishes tells power manager back that it's ready to
suspend (via HandleSuspendReadiness).

BUG=b:70811583, chromium:807454 
TEST=Run newblued in a chromebook, trigger suspend discovery with
powerd_dbus_suspend and verify that bluetooth daemon responds to powerd
signals correctly. Unit test is also available.
CQ-DEPEND=CL:900207

Change-Id: I76f1cfc165bbbce65001607891f6e9412d57efd4
Reviewed-on: https://chromium-review.googlesource.com/899923
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/367495175ada4bd65616acced0f143015304dac8/bluetooth/newblued/main.cc
[add] https://crrev.com/367495175ada4bd65616acced0f143015304dac8/bluetooth/newblued/complete_mock_object_proxy.h
[modify] https://crrev.com/367495175ada4bd65616acced0f143015304dac8/PRESUBMIT.cfg
[add] https://crrev.com/367495175ada4bd65616acced0f143015304dac8/bluetooth/bluetooth.gyp
[add] https://crrev.com/367495175ada4bd65616acced0f143015304dac8/bluetooth/OWNERS
[add] https://crrev.com/367495175ada4bd65616acced0f143015304dac8/bluetooth/newblued/daemon.cc
[add] https://crrev.com/367495175ada4bd65616acced0f143015304dac8/bluetooth/README.md
[add] https://crrev.com/367495175ada4bd65616acced0f143015304dac8/bluetooth/newblued/daemon_unittest.cc
[modify] https://crrev.com/367495175ada4bd65616acced0f143015304dac8/README.md
[add] https://crrev.com/367495175ada4bd65616acced0f143015304dac8/bluetooth/newblued/daemon.h

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fcb8fc9c22b770475feda9f9066a4f27faa2e226

commit fcb8fc9c22b770475feda9f9066a4f27faa2e226
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Thu Feb 08 02:18:54 2018

Add ebuild for Bluetooth service.

BUG=b:70811583, chromium:807454 
TEST=emerge-$BOARD bluetooth
CQ-DEPEND=CL:899923

Change-Id: If3c06a94f612cb0f7e223df789bbda7072fe12d4
Reviewed-on: https://chromium-review.googlesource.com/899513
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/fcb8fc9c22b770475feda9f9066a4f27faa2e226/chromeos-base/bluetooth/bluetooth-9999.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/144064dc746a7cbdccfbac7e4fca87bb7e2a7626

commit 144064dc746a7cbdccfbac7e4fca87bb7e2a7626
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Fri Feb 09 07:42:26 2018

bluetooth: Add upstart init config file

This CL adds upstart init config file and additionally resolves small
issues that were not addressed in the previous patch (CL:899923):
* Replace new unique_ptr with std::make_unique
* Clean up constructor and destructor style

BUG= chromium:807454 
TEST=cros deploy to a chromebook, reboot and check that newblued is
started automatically. Kill the process and check that another newblued
process is respawn.
Change-Id: Ie6761b83c3b642bdce2ff0594e3945d8b2248546
Reviewed-on: https://chromium-review.googlesource.com/907215
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/144064dc746a7cbdccfbac7e4fca87bb7e2a7626/bluetooth/newblued/daemon_unittest.cc
[add] https://crrev.com/144064dc746a7cbdccfbac7e4fca87bb7e2a7626/bluetooth/init/upstart/newblued.conf

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5ce55fbd73aae1f95189f5fadd037ac95abf4df4

commit 5ce55fbd73aae1f95189f5fadd037ac95abf4df4
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Fri Feb 09 10:20:04 2018

bluetooth: Install upstart init config file

BUG= chromium:807454 
TEST=cros deploy to a chromebook, reboot and check that newblued is
started automatically. Kill the process and check that another newblued
is respawn.
CQ-DEPEND=CL:907215,CL:899513,CL:904971

Change-Id: I85e716c77b729158a97faf6e76609de788429113
Reviewed-on: https://chromium-review.googlesource.com/907381
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5ce55fbd73aae1f95189f5fadd037ac95abf4df4/chromeos-base/bluetooth/bluetooth-9999.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/72a9fd1afb653eecf4087fa54ec67f52a2ae1e56

commit 72a9fd1afb653eecf4087fa54ec67f52a2ae1e56
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Sat Feb 10 03:03:24 2018

bluetooth: Install seccomp policy file

BUG= chromium:807454 
TEST=run emerge-$BOARD with and without USE=seccomp
CQ-DEPEND=CL:907381

Change-Id: I7c862278736b3b373edc0cb090ee843b637a67bd
Reviewed-on: https://chromium-review.googlesource.com/910391
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/72a9fd1afb653eecf4087fa54ec67f52a2ae1e56/chromeos-base/bluetooth/bluetooth-9999.ebuild

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2b7ad81aaeb78d76f8b70376854d21de04439648

commit 2b7ad81aaeb78d76f8b70376854d21de04439648
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Wed Feb 14 01:40:51 2018

bluetooth: Add seccomp policy for amd64

BUG= chromium:807454 
TEST=run emerge-$BOARD with and without USE=seccomp
CQ-DEPEND=CL:907215,CL:910391

Change-Id: I16d75bfc10d049ce5ea134c0a62dd9eaf0446af7
Reviewed-on: https://chromium-review.googlesource.com/910392
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/2b7ad81aaeb78d76f8b70376854d21de04439648/bluetooth/init/upstart/newblued.conf
[add] https://crrev.com/2b7ad81aaeb78d76f8b70376854d21de04439648/bluetooth/seccomp_filters/newblued-seccomp-amd64.policy

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bedb8c18bcdde5c0dfe89e6600667f27605f60ac

commit bedb8c18bcdde5c0dfe89e6600667f27605f60ac
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Wed Feb 14 21:05:12 2018

bluetooth: Add chromeos-base/libbrillo as runtime dependency

BUG= chromium:807454 
TEST=emerge-$BOARD from a clean build and build should succeed

Change-Id: Ia5ac521d7178243795bd4fef1b52e54368cf0def
Reviewed-on: https://chromium-review.googlesource.com/918042
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/bedb8c18bcdde5c0dfe89e6600667f27605f60ac/chromeos-base/bluetooth/bluetooth-9999.ebuild

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b2dea4d69565a169836199b53d2dd748465ea483

commit b2dea4d69565a169836199b53d2dd748465ea483
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Fri Feb 16 01:42:24 2018

target-chromium-os: add chromeos-base/bluetooth to replace bluez

chromeos-base/bluetooth replaces bluez but still depends on bluez.

BUG= chromium:812013 , chromium:807454 ,b:70811583
TEST=equery-$BOARD g target-chromium-os

Change-Id: Icb3749877c33ccfbc53b13c8d4c1b3e1b2e9f720
Reviewed-on: https://chromium-review.googlesource.com/917324
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b2dea4d69565a169836199b53d2dd748465ea483/chromeos-base/bluetooth/bluetooth-9999.ebuild
[rename] https://crrev.com/b2dea4d69565a169836199b53d2dd748465ea483/virtual/target-chromium-os/target-chromium-os-1-r86.ebuild
[modify] https://crrev.com/b2dea4d69565a169836199b53d2dd748465ea483/virtual/target-chromium-os/target-chromium-os-1.ebuild

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/43728a93f6de137006c6b92fbb2a7cc4f353c9bf

commit 43728a93f6de137006c6b92fbb2a7cc4f353c9bf
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Fri Feb 16 01:42:27 2018

bluetooth: Add seccomp policy for arm

BUG= chromium:807454 
TEST=run emerge-$BOARD with and without USE=seccomp
CQ-DEPEND=CL:910392

Change-Id: I55bd011e3a5fc36b83105aeff38096ee8d850be2
Reviewed-on: https://chromium-review.googlesource.com/914813
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/43728a93f6de137006c6b92fbb2a7cc4f353c9bf/bluetooth/seccomp_filters/newblued-seccomp-arm.policy

Status: Fixed (was: Assigned)

Sign in to add a comment