New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807450 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Predator] Ignore anonymous namespace:: or something like that when matching frame function with crash_state

Project Member Reported by kateso...@chromium.org, Jan 30 2018

Issue description

[Predator] Ignore anonymous namespace:: or others when matching frame function with crash_state

https://bugs.chromium.org/p/chromium/issues/detail?id=805970
 
Summary: [Predator] Ignore anonymous namespace:: or something like that when matching frame function with crash_state (was: [Predator] Ignore anonymous namespace:: or others when matching frame function with crash_state)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d0b138cd09b095f66b025aba42e943fa6fdb2601

commit d0b138cd09b095f66b025aba42e943fa6fdb2601
Author: Sharu Jiang <katesonia@google.com>
Date: Thu Feb 01 23:59:29 2018

[Predator] Strip parentheses in function name when matching with crash_state.

For a testcase like this: https://clusterfuzz.com/v2/testcase-detail/6243299485286400
the function in crash_state is:
v8::internal::CompileRunAndVerify

However in stacktrace the function in frame is:
v8::internal::(anonymous namespace)::CompileRunAndVerify(v8::internal::(anonymous namespace)::FuzzerArgs*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)


Strip the parentheses to match these 2.

Bug:  807450 
Change-Id: I25c602b13a5c896cc388b709b1cb2ebdcb3834f0
Reviewed-on: https://chromium-review.googlesource.com/894371
Commit-Queue: Sharu Jiang <katesonia@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/d0b138cd09b095f66b025aba42e943fa6fdb2601/appengine/predator/analysis/callstack_filters.py
[modify] https://crrev.com/d0b138cd09b095f66b025aba42e943fa6fdb2601/appengine/predator/analysis/test/crash_util_test.py
[modify] https://crrev.com/d0b138cd09b095f66b025aba42e943fa6fdb2601/appengine/predator/analysis/crash_util.py

Status: Fixed (was: Assigned)

Sign in to add a comment