New issue
Advanced search Search tips

Issue 807438 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

flashrom: CONFIG_INTERNAL should depend on CONFIG_LINUX_I2C on arm

Project Member Reported by dnschn...@chromium.org, Jan 30 2018

Issue description

Trying to compile flashrom with a minimum number of drivers.  I'm probably just being annoying now, but I figure I might as well file bugs I find.

CONFIG_INTERNAL brings in cros_ec_i2c when compiled on arm-based architectures.  cros_ec_i2c in turn depends on CONFIG_LINUX_I2C, but that's not auto-enabled as a dependency in the Makefile.  Without it, compile fails:


cc  -o flashrom flashrom.o cli_mfg.o cli_output.o print.o jedec.o stm50flw0x0x.o w39.o w29ee011.o sst28sf040.o m29f400bt.o 82802ab.o pm49fl00x.o sst49lfxxxc.o sst_fwhub.o flashchips.o spi.o spi25.o sharplhf00l04.o a25.o at25.o s25f.o spi4ba.o opaque.o writeprotect.o udelay.o programmer.o processor_enable.o chipset_enable.o board_enable.o cbtable.o dmi.o internal.o cros_ec.o cros_ec_i2c.o cros_ec_dev.o bitbang_spi.o ft2232_spi.o dummyflasher.o buspirate_spi.o raiden_debug_spi.o usb_device.o dediprog.o linux_spi.o pcidev.o physmap.o hwaccess.o android.o layout.o file.o fmap.o power.o search.o big_lock.o file_lock.o cros_ec_lock.o # Always enable FT2232 SPI dongles for now.
serial.o  -lpci -lftdi   -lusb-1.0
cros_ec_i2c.o: In function `cros_ec_i2c_shutdown':
# Grab hdctools
cros_ec_i2c.c:(.text+0x14): undefined reference to `linux_i2c_shutdown'
cros_ec_i2c.o: In function `command_response':
cros_ec_i2c.c:(.text+0x188): undefined reference to `linux_i2c_xfer'
cros_ec_i2c.o: In function `cros_ec_command_i2c':
cros_ec_i2c.c:(.text+0x480): undefined reference to `linux_i2c_xfer'
cros_ec_i2c.o: In function `cros_ec_probe_i2c':
cros_ec_i2c.c:(.text+0x9ac): undefined reference to `linux_i2c_open'
cros_ec_i2c.c:(.text+0x9dc): undefined reference to `linux_i2c_close'
collect2: error: ld returned 1 exit status
Makefile:858: recipe for target 'flashrom' failed
 

Sign in to add a comment