New issue
Advanced search Search tips

Issue 807420 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

InteractionMediaQueriesDynamicTest.PointerMediaQueriesDynamic is failing on asan-clang-phone

Project Member Reported by mariakho...@chromium.org, Jan 30 2018

Issue description

Started failing between January 15th and January 19th and has been failing consistently since. Unfortunately the bot was purple in between those dates, so it's hard to narrow down the cause of the failures.

https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-clang-phone/builds/3693 has first failure
everything in between is purple and didn't run tests
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-clang-phone/builds/3621 NO FAILURE


Failure output:
C 7952.966s Main  [UNKNOWN] InteractionMediaQueriesDynamicTest.PointerMediaQueriesDynamic:
C 7952.966s Main  [ RUN      ] InteractionMediaQueriesDynamicTest.PointerMediaQueriesDynamic
C 7952.966s Main  [WARNING:dns_config_service_posix.cc(329)] Failed to read DnsConfig.
C 7952.966s Main  [ERROR:devtools_http_handler.cc(249)] Cannot start http server for devtools. Stop devtools.
C 7952.966s Main  [WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file assets/snapshot_blob_64.bin
C 7952.966s Main  [ERROR:shell_android.cc(78)] Not implemented reached in void content::Shell::PlatformSetTitle(const base::string16 &): Dynamic interaction media query test
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d0ba81da6e3e741a1d11909175ac4ccb6d6a03d

commit 4d0ba81da6e3e741a1d11909175ac4ccb6d6a03d
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Wed Jan 31 22:43:56 2018

Disable PointerMediaQueriesDynamic

Disabling on ASAN bot due to consistent failures.

BUG=807420
TBR=tdresser@chromium.org,dtapuska@chromium.org

Change-Id: Ib2990fa9c31582382f14d6a2ce7e6c2b1614c54d
Reviewed-on: https://chromium-review.googlesource.com/896224
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533452}
[modify] https://crrev.com/4d0ba81da6e3e741a1d11909175ac4ccb6d6a03d/content/browser/renderer_host/input/interaction_mq_dynamic_browsertest.cc

Labels: Test-Disabled
Owner: mustaq@chromium.org
Status: Assigned (was: Untriaged)
mustaq@ please investigate.
Btw, I confirmed that #c4 is about disabling the failure to fix the tree (and not fixing the core problem in our code).

The test sets document.title to mark success/failure.  For Android, the test reaches this implemented code and fails:
https://cs.chromium.org/chromium/src/content/shell/browser/shell_android.cc?rcl=66ef4b791cf0c4bb1314fb039e18e0b7ec6a9492&l=77

Why doesn't this fail on non-ASA bots?

On lollipop phone tester I see it get to NOTREACHED as well, but the test succeeds:

I  526.685s run_tests_on_device(0490824722390b29)  [ RUN      ] InteractionMediaQueriesDynamicTest.PointerMediaQueriesDynamic
I  526.685s run_tests_on_device(0490824722390b29)  [WARNING:dns_config_service_posix.cc(350)] Failed to read DnsConfig.
I  526.685s run_tests_on_device(0490824722390b29)  [ERROR:devtools_http_handler.cc(249)] Cannot start http server for devtools. Stop devtools.
I  526.685s run_tests_on_device(0490824722390b29)  [WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file assets/snapshot_blob_64.bin
I  526.685s run_tests_on_device(0490824722390b29)  [ERROR:shell_android.cc(78)] Not implemented reached in void content::Shell::PlatformSetTitle(const base::string16 &): Dynamic interaction media query test
I  526.685s run_tests_on_device(0490824722390b29)  [ERROR:shell_android.cc(78)] Not implemented reached in void content::Shell::PlatformSetTitle(const base::string16 &): SUCCESS
I  526.685s run_tests_on_device(0490824722390b29)  referenceTable head length=54 1
I  526.685s run_tests_on_device(0490824722390b29)  [       OK ] InteractionMediaQueriesDynamicTest.PointerMediaQueriesDynamic (938 ms)
Hmm, good point.  My guess is clearly wrong!

Upon a closer look at the stdout for the original failure reported here (link below), I see that the NOTREACHED error at shell_android.cc(78) is for pre-test HTML title "Dynamic interaction media query test" which is changed later (at the end of the test) to either "SUCCESS" or "FAILURE" for which there is no further NOTREACHED failure!
https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.client.clank%2Fasan-clang-phone%2F3693%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests%2F0%2Fstdout

Here is a similar log for a successful run (see https://chromium-review.googlesource.com/904724) which shows the same outcome (NOTREACHED for initial title, but not for subsequent ones):
https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.android%2Flinux_android_dbg_ng%2F1400%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests__with_patch__on_Android%2F0%2Fstdout

Any chance this points to a test setup issue?
Labels: -Pri-1 Pri-2

Comment 10 Deleted

Sorry, wrong bug number :-(
Labels: Hotlist-DisableReview

Sign in to add a comment