New issue
Advanced search Search tips

Issue 807412 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

flashrom: CONFIG_INTERNAL doesn't properly depend on libpci

Project Member Reported by dnschn...@chromium.org, Jan 30 2018

Issue description

Trying to compile flashrom with a minimum number of drivers.

Enabling CONFIG_INTERNAL (due to issue 807410) doesn't seem to properly pull in the libpci dependency on its own.

Looking at the Makefile, it appears that libpci is only marked as a dependency if the architecture is not x86, but a lot of stuff at least depends on the pci_dev struct.  Perhaps the NEED_LIBPCI line is supposed to be one line lower?


ifeq ($(CONFIG_INTERNAL), yes)
FEATURE_CFLAGS += -D'CONFIG_INTERNAL=1'
PROGRAMMER_OBJS += processor_enable.o chipset_enable.o board_enable.o cbtable.o dmi.o internal.o cros_ec.o
ifeq ($(ARCH),x86)
PROGRAMMER_OBJS += cros_ec_lpc.o it87spi.o it85spi.o mec1308.o sb600spi.o wbsio_spi.o mcp6x_spi.o wpce775x.o ene_lpc.o
PROGRAMMER_OBJS += ichspi.o ich_descriptors.o amd_imc.o
else
ifeq ($(ARCH),arm)
PROGRAMMER_OBJS += cros_ec_i2c.o
endif
NEED_LIBPCI += CONFIG_INTERNAL
endif
endif
 

Sign in to add a comment