Skia/NaCl DEPS auto-roller retries failures in tight loop, wastes resources |
||
Issue descriptionThe DEPS auto-roller that is used for Skia and NaCl (https://nacl-roll.skia.org/) will retry any failure immediately. If a roll consistently fails, this will lead to the auto-roller creating large numbers of CLs and CQ jobs, which wastes resources, generates a lot of e-mail, and isn't very useful. For example, see this list of CLs: https://chromium-review.googlesource.com/q/owner:nacl-chromium-autoroll%40skia-buildbots.google.com.iam.gserviceaccount.com The NaCl roller is currently failing ( issue 807387 ), so I'm disabling it. Some kind of exponential back-off for retries would be useful.
,
Feb 9 2018
Okay, we've switched to retrying the CQ for failed rolls rather than closing the CL and opening another, which should result in fewer bots being run and all of the emails ending up in the same thread, so it'll be less noisy and use fewer resources. In addition, https://skia-review.googlesource.com/c/buildbot/+/105765 causes us to wait an hour before retrying the CQ a failed roll (unless a new commit has landed or the roller is stopped). I think this should be mitigated enough to close the bug. Please let me know if you disagree.
,
Feb 9 2018
Thanks for making that change! |
||
►
Sign in to add a comment |
||
Comment 1 by bore...@google.com
, Jan 31 2018