New issue
Advanced search Search tips

Issue 807391 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

warnings compiling unrar

Project Member Reported by wfh@chromium.org, Jan 30 2018

Issue description

Chrome Version: 66.0.3335.0 git rev 1063641d0bf9b23449f758d7e0de55b7611dcc06
OS: Win10

What steps will reproduce the problem?
(1) use gn flags:

c:\src\gclient\src>type out\gnrelease64\args.gn
# Build arguments go here. Examples:
#   is_component_build = true
#   is_debug = false
# See "gn args <out_dir> --list" for available build arguments.
is_component_build = false
is_debug = false
target_cpu = "x64"
enable_nacl = false
remove_webcore_debug_symbols = true
is_chrome_branded = true
is_clang = true
dcheck_always_on = true

(2) compile chrome
(3)

What is the expected result?

no warnings

What happens instead?

warnings shown:

ninja: Entering directory `out\default'
[1/1] Regenerating ninja files
[237/26285] CXX obj/third_party/unrar/unrar/unicode.obj
../../third_party/unrar/src/unicode.cpp(302,17):  warning: result of comparison of constant 65536 with expression of type 'const wchar' (aka 'const wchar_t') is always true [-Wtautological-constant-out-of-range-compare]
        if (*Src<0x10000)
            ~~~~^~~~~~~~
../../third_party/unrar/src/unicode.cpp(313,19):  warning: result of comparison of constant 2097152 with expression of type 'const wchar' (aka 'const wchar_t') is always true [-Wtautological-constant-out-of-range-compare]
          if (*Src<0x200000)
              ~~~~^~~~~~~~~
2 warnings generated.
[412/26285] CXX obj/third_party/unrar/unrar/strfn.obj
../../third_party/unrar/src/strfn.cpp(124,34):  warning: cast to 'char *' from smaller integer type 'unsigned char' [-Wint-to-pointer-cast]
  return (int)(LPARAM)CharLowerA((LPSTR)ch);
                                 ^
../../third_party/unrar/src/strfn.cpp(135,34):  warning: cast to 'char *' from smaller integer type 'unsigned char' [-Wint-to-pointer-cast]
  return (int)(LPARAM)CharUpperA((LPSTR)ch);
                                 ^
2 warnings generated.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by wfh@chromium.org, Jan 30 2018

Cc: nparker@chromium.org
Owner: vakh@chromium.org
Status: Assigned (was: Untriaged)
assigning based on owners

Comment 2 by wfh@chromium.org, Jan 30 2018

just thinking about this more, I'm surprised this even landed - we normally treat warnings as errors, so unsure how this got past the trybots...? :confused:
I've seen plenty of cases where trybots don't have 100% coverage.  I suspect this needs more flags to turn off more warnings on Windows.

Comment 4 by gab@chromium.org, Jan 31 2018

Labels: -Pri-2 Pri-1
Another set of GN args for which this repros.

"""
target_cpu = "x86"
is_component_build = true
is_debug = false
enable_nacl = false

use_goma = true
goma_dir = "C:\src\goma\goma-win64"
"""


-Werror must not be applied to that target (that's bad), shall we revert r531767 + r531926?

Warning in the build are P1 and not acceptable.

Comment 5 by wfh@chromium.org, Jan 31 2018

Cc: brucedaw...@chromium.org
it's curious that -Werror (clang) or /WX (MSVC) isn't on by default for all projects/components in Chrome, unless specifically turned off. This would have prevented this from landing in the first place.

Bruce - do you know why /WX or -Werror isn't on for this library? Does this mean it's possibly not on for all of Chromium?

Comment 6 by vakh@chromium.org, Jan 31 2018

Status: Started (was: Assigned)

Comment 7 by vakh@chromium.org, Jan 31 2018

Reverting the newer CL first: https://chromium-review.googlesource.com/c/chromium/src/+/894999

Once that lands, I'll submit the older CL.
It looks like on Windows -Werror is only on for projects that have the chromium_code config - on other platforms -Werror is on for all (as long as clang is used as the compiler).

I think the right fix is to have -Werror be on whenever clang is the compiler, on all platforms. I am creating a CL to do this.
We pass /WX for everything and clang-cl honors this. I've seen this target warn on Linux too. I don't understand why werror didn't work. It's on my list of things to investigate. Very curious.
I was looking at the no_chromium_code config which looked like it only enabled -Werror on non-Windows builds, so that was my assumption of the problem. But, changing that didn't help (and wouldn't explain how the warnings happened on Linux).

It turns out the problem is much simpler: the unrar library was removing the chromium_code config but it wasn't adding back in the no_chromium_code config. Doing that turns on -Werror and causes the build to fail - with even more warnings.

So, I guess the fix for this particular problem is to add the no_chromium_code config and suppress some warnings, but that leaves the larger problem of preventing projects from being built with neither chromium_code nor no_chromium_code.
Oof, that'd do it. In hindsight, surprising we never consciously ran into this before.
"//build/config/compiler:chromium_code" - 260 hits
"//build/config/compiler:no_chromium_code" - 256 hits

So, assuming that chromium_code is added once by default and is then subtracted 259 times that suggests 3 bugs, maybe?

A more precise analysis should be easy enough, but a way of preventing this completely would be ideal.

The treat_warnings_as_errors handling code in build\config\compiler\BUILD.gn seems needlessly complicated, but it isn't wrong as I initially suspected from inspecting the no_chromium_code config.

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f8244c8554200766daa806b36baa620f391445

commit 95f8244c8554200766daa806b36baa620f391445
Author: Varun Khaneja <vakh@chromium.org>
Date: Thu Feb 01 15:52:33 2018

Revert "[1] Add unrar source code (v5.6.1.4) to third_party."

This reverts commit 0941a32d0fe8820862a438e2dc3a1a19c0af41b2.

Reason for revert: Causing build failures https://bugs.chromium.org/p/chromium/issues/detail?id=807391

Original change's description:
> [1] Add unrar source code (v5.6.1.4) to third_party.
>
> Safe Browsing Download Protection for .RAR files:
> This library will be used to unpack any .rar files
> downloaded by the user to ensure that they are safe.
> This code would execute inside a sandboxed process.
>
> This code is being fuzzed via OSS-Fuzz here:
> https://github.com/google/oss-fuzz/tree/master/projects/unrar
>
> Here's the author's permission to use this library
> for fuzzing and inclusion in Chrome: http://go/wknlc
>
> Followed the process listed at:
> https://chromium.googlesource.com/chromium/src.git/+/master/docs/adding_to_third_party.md
>
> Bug: 750327
> Change-Id: Ia6978fcf43f1ba570d6e8dad5daf2903cbdb3834
> Reviewed-on: https://chromium-review.googlesource.com/855044
> Commit-Queue: Varun Khaneja <vakh@chromium.org>
> Reviewed-by: Justin Schuh <jschuh@chromium.org>
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Reviewed-by: Jialiu Lin <jialiul@chromium.org>
> Reviewed-by: Nathan Parker <nparker@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531767}

TBR=thakis@chromium.org,jschuh@chromium.org,xam@google.com,nparker@chromium.org,vakh@chromium.org,jialiul@chromium.org,rend@google.com,jschuh@google.com,morbo@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 750327,  807391 
Change-Id: Id2494b74b1eceebd67cef769219e0b2149dad8d9
Reviewed-on: https://chromium-review.googlesource.com/895399
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533682}
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/BUILD.gn
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/LICENSE
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/OWNERS
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/README.chromium
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/acknow.txt
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/arccmt.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/archive.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/archive.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/arcmem.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/arcmem.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/arcread.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/array.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/blake2s.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/blake2s.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/blake2s_sse.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/blake2sp.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/cmddata.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/cmddata.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/coder.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/coder.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/compress.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/consio.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/consio.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/crc.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/crc.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/crypt.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/crypt.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/crypt1.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/crypt2.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/crypt3.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/crypt5.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/dll.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/dll.def
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/dll.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/dll.rc
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/encname.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/encname.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/errhnd.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/errhnd.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/extinfo.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/extinfo.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/extract.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/extract.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/filcreat.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/filcreat.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/file.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/file.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/filefn.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/filefn.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/filestr.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/filestr.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/find.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/find.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/getbits.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/getbits.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/global.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/global.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/hardlinks.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/hash.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/hash.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/headers.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/headers.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/headers5.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/isnt.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/isnt.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/license.txt
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/list.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/list.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/loclang.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/log.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/log.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/makefile
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/match.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/match.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/model.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/model.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/options.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/options.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/os.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/pathfn.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/pathfn.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/qopen.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/qopen.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rar.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rar.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rardefs.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rarlang.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/raros.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rarpch.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rartypes.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rarvm.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rarvm.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rawint.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rawread.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rawread.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rdwrfn.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rdwrfn.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/readme.txt
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/recvol.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/recvol.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/recvol3.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/recvol5.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/resource.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/resource.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rijndael.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rijndael.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rs.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rs.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rs16.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/rs16.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/savepos.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/scantree.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/scantree.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/secpassword.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/secpassword.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/sha1.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/sha1.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/sha256.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/sha256.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/smallfn.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/smallfn.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/strfn.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/strfn.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/strlist.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/strlist.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/suballoc.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/suballoc.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/system.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/system.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/threadmisc.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/threadpool.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/threadpool.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/timefn.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/timefn.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/ui.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/ui.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/uicommon.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/uiconsole.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/uisilent.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/ulinks.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/unicode.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/unicode.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/unpack.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/unpack.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/unpack15.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/unpack20.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/unpack30.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/unpack50.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/unpack50frag.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/unpack50mt.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/unpackinline.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/uowners.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/version.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/volume.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/volume.hpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/win32acl.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/win32lnk.cpp
[delete] https://crrev.com/c0abee7bfdf673de39e7c30af1a268b05a989c63/third_party/unrar/src/win32stm.cpp

Comment 14 by vakh@chromium.org, Feb 2 2018

Status: Fixed (was: Started)

Sign in to add a comment