New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 807388 link

Starred by 1 user
Status: Fixed
Owner:
█ kbr@chromium.org
OOO until 2019-01-24
Closed: Mar 2018
Cc:
geoffl...@chromium.org
jmad...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 850295
issue 859224
issue 851477



Sign in to add a comment

smoothness.tough_webgl_cases / http___webglsamples.org_aquarium_aquarium.html doesn't use enough fish

Project Member Reported by jmad...@chromium.org, Jan 30 2018 
See this report:

https://chromeperf.appspot.com/report?sid=0ef59039de7ec9f56d4e1ae0b7997fc21f432fda0fd2acb87398ad94b6c18627&start_rev=481508&end_rev=532851

Here you can see two benchmarks, one which shows a very significant improvement (animometer WebGL) from Geoff's CL to turn on the pass-through command buffer, and one which doesn't (WebGL Aquarium). I think what's happening here is the aquarium benchmark is using too few fish, and is having an easy time to render the 100 fish capped at 60 fps (hence the 16ms mean frame time).

Ken, can we easily crank up the number of fish?

Comment 1 by kbr@chromium.org, Jan 30 2018 

Yes, we can. What would need to be done is to re-record the smoothness.tough_webgl_cases page set, but changing the Aquarium's URL to something like:

http://webglsamples.org/aquarium/aquarium.html?numFish=10000

using tools/perf/record_wpr .

Actually, I'll plan to record a newly-named benchmark like "aquarium_10000" instead of re-recording the existing benchmark and completely changing the baseline.

How many fish do you want?

Comment 2 by jmad...@chromium.org, Jan 30 2018 

10k is maybe enough, but on my local machine it locks at 60fps. This is a powerful machine, but probably safer to use something like 20k I think.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Mar 7 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12c37ab2440000
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Mar 7 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/15a95a12440000
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Mar 7 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/14cebe8a440000
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Mar 7 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12a82032440000
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/338cfa6d6375dd94f82e1efe7bb5d5c1e7a3fbc8

commit 338cfa6d6375dd94f82e1efe7bb5d5c1e7a3fbc8
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Mar 09 00:03:07 2018

Add new aquarium_20k page to smoothness.tough_webgl_cases.

Re-recorded the page set on Linux with:
  ./tools/perf/record_wpr --browser=system tough_webgl_cases_page_set

Uploaded the result with:
  depot_tools/upload_to_google_storage.py --bucket chromium-telemetry \
    tools/perf/page_sets/data/tough_webgl_cases_006.wprgo

Bug:  807388 
Change-Id: Ie497ef20c5bb0e15fa829e2016e3793ec9ece9f3
Reviewed-on: https://chromium-review.googlesource.com/936324
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#541945}
[modify] https://crrev.com/338cfa6d6375dd94f82e1efe7bb5d5c1e7a3fbc8/tools/perf/page_sets/data/tough_webgl_cases.json
[add] https://crrev.com/338cfa6d6375dd94f82e1efe7bb5d5c1e7a3fbc8/tools/perf/page_sets/data/tough_webgl_cases_006.wprgo.sha1
[modify] https://crrev.com/338cfa6d6375dd94f82e1efe7bb5d5c1e7a3fbc8/tools/perf/page_sets/tough_webgl_cases.py

Comment 13 by kbr@chromium.org, Mar 9 2018

Status: Fixed (was: Assigned)
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Mar 9 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/161a5f6c440000

Comment 15 by kbr@chromium.org, Jun 29 2018

Blocking: 850295

Comment 16 by kbr@chromium.org, Jun 29 2018

Blocking: 851477

Comment 17 by kbr@chromium.org, Jun 29 2018

Blocking: 859224
►

Sign in to add a comment