New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807387 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NaCl DEPS auto-roller failing on linux_nacl_sdk_build bot

Project Member Reported by mseaborn@chromium.org, Jan 30 2018

Issue description

The NaCl DEPS auto-roller (https://nacl-roll.skia.org/) currently repeatedly fails.

Example of a failed roll CL:
https://chromium-review.googlesource.com/c/chromium/src/+/893882

Example of failed trybot run:
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_nacl_sdk_build/1283

It's not clear what the actual reason for the failure is, apart from this output:
"Step('annotated_steps') failed with return_code 1"
- from https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_nacl_sdk_build%2F1283%2F%2B%2Frecipes%2Fsteps%2FFailure_reason%2F0%2Flogs%2Freason%2F0

I am disabling the NaCl auto-roller for now because of this.
 

Comment 1 by bore...@google.com, Jan 30 2018

Unfortunately I'm no help in actually diagnosing what's wrong.  The roller has been switched to use a new account: https://chromium-review.googlesource.com/dashboard/nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com

The old account last uploaded a roll attempt on Jan 10: https://chromium-review.googlesource.com/c/chromium/src/+/858964.  The same bot failed on that CL.
The auto-roller is adding this line to the commit message:

  CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build

Can we remove that from the auto-roller's config, so that the rolls just use the default set of trybots?

Comment 3 by bore...@google.com, Jan 31 2018

Done in https://skia-review.googlesource.com/#/c/buildbot/+/102140.  I'll post back here when that has landed and is pushed to the server.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://skia.googlesource.com/buildbot/+/f49f515672bf8d39b21abe637d17a752bd5c0903

commit f49f515672bf8d39b21abe637d17a752bd5c0903
Author: Eric Boren <borenet@google.com>
Date: Wed Jan 31 12:54:13 2018

[autoroll] Remove extra trybots from NaCl roller

Bug:  807387 
Change-Id: Ib6e0b7e846c80c8fb8967de7c253f249d7b58f1c
Reviewed-on: https://skia-review.googlesource.com/102140
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>

[modify] https://crrev.com/f49f515672bf8d39b21abe637d17a752bd5c0903/autoroll/sys/nacl-autorolld.service

Comment 5 by bore...@google.com, Jan 31 2018

Okay, the above has been pushed.  New rolls will not have the extra trybots.  I'll leave it up to you to re-enable the roller when you're ready.
Status: Fixed (was: Untriaged)
Thanks for making that change!  That has fixed the problem -- recent rolls passed (e.g. https://chromium-review.googlesource.com/c/chromium/src/+/899958).

Sign in to add a comment