New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 807386 link

Starred by 1 user
Status: Assigned
Owner:
droger@chromium.org
Cc:
droger@chromium.org
█ juliatut...@chromium.org
msarda@chromium.org
thakis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

"BrowserProcessImplTest.LifeCycle" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 30 2018 
"BrowserProcessImplTest.LifeCycle" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBCcm93c2VyUHJvY2Vzc0ltcGxUZXN0LkxpZmVDeWNsZQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by bsep@chromium.org, Jan 31 2018

Cc: droger@chromium.org juliatut...@chromium.org
Labels: OS-Linux
It's only flaky on the TSAN bot, which says there's a data race between ~MutableProfileOAuth2TokenServiceDelegate and NetworkChangeNotifier's constructor. I feel like that indicates a real bug somewhere.

I'll disable the test for now. CCing a net OWNER and a signin OWNER.

Comment 2 by bsep@chromium.org, Jan 31 2018

Cc: thakis@chromium.org msarda@chromium.org
Labels: -Sheriff-Chromium Test-Disabled
Disabling as https://chromium-review.googlesource.com/c/chromium/src/+/894986

I noticed that ~ProfileManager is also in the trace, so also adding a profile OWNER, and an OWNER for the test itself (I don't really know what the bug is).
Project Member

Comment 3 by chromium...@appspot.gserviceaccount.com, Jan 31 2018

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "BrowserProcessImplTest.LifeCycle". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBCcm93c2VyUHJvY2Vzc0ltcGxUZXN0LkxpZmVDeWNsZQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 4 by rouslan@chromium.org, Jan 31 2018

Labels: -Sheriff-Chromium
Owner: msarda@chromium.org
Please help triage.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0054ee9dac4705d4f70edb66a907fe4bde473b25

commit 0054ee9dac4705d4f70edb66a907fe4bde473b25
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Jan 31 22:25:07 2018

Disable BrowserProcessImplTest.LifeCycle (flaky on TSAN bot).

TBR=thakis@chromium.org

Bug: 807386
Change-Id: I2cdffa36f5340ca3a359627c9ff3a399e06e81f4
Reviewed-on: https://chromium-review.googlesource.com/894986
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533444}
[modify] https://crrev.com/0054ee9dac4705d4f70edb66a907fe4bde473b25/chrome/browser/browser_process_impl_unittest.cc

Comment 6 by msarda@chromium.org, Jul 2

Owner: droger@chromium.org
Status: Assigned (was: Untriaged)
David: Would you have time to take a look at this bug?

Comment 7 by droger@chromium.org, Jul 2 

I actually wrote that test. I don't really have time to look into it now, but will do when I have the opportunity.
►

Sign in to add a comment