New issue
Advanced search Search tips

Issue 807379 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Feb 2018
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 771643



Sign in to add a comment

[SPv175] Incorrect clip for SVG masks

Project Member Reported by wangxianzhu@chromium.org, Jan 30 2018 
Two tests are affected:
svg/batik/masking/maskRegions.svg
paint/invalidation/svg/absolute-sized-content-with-resources.xhtml

            <mask id="mask" maskUnits="userSpaceOnUse" x="25" y="20" width="50" height="40">
                <circle cx="25" cy="20" r="20" fill="#ffffff" />
                <circle cx="25" cy="60" r="20" fill="#ffffff" />
                <circle cx="75" cy="20" r="20" fill="#ffffff" />
                <circle cx="75" cy="60" r="20" fill="#ffffff" />
            </mask>

The mask's x, y, width, height are not respected.

Comment 1 by wangxianzhu@chromium.org, Jan 30 2018 

Failure of svg/zoom/page/zoom-mask-with-percentages.svg may be because of the same reason, but instead of missing clip, we apply a clip that may be 1 pixel smaller than expected.

Comment 2 by wangxianzhu@chromium.org, Jan 31 2018

Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)

Comment 3 by wangxianzhu@chromium.org, Jan 31 2018 

 Issue 807374  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04e20c3f63e2f9691ccaba746a71b6eb067d0639

commit 04e20c3f63e2f9691ccaba746a71b6eb067d0639
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Feb 01 06:13:48 2018

[SPv175+] Correct SVG mask clip

Consider <mask> element's bounds.

Bug:  807379 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2f78202095881318f9d8b09c190354ea2b9decd6
Reviewed-on: https://chromium-review.googlesource.com/896232
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533590}
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v175
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/89d19f291c8a471a7da51a6bf7bbb62e1b26adb3/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png
[add] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/as-background-image/svg-as-background-6-expected.png
[add] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/batik/masking/maskRegions-expected.png
[add] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/custom/grayscale-gradient-mask-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png
[delete] https://crrev.com/89d19f291c8a471a7da51a6bf7bbb62e1b26adb3/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png
[delete] https://crrev.com/89d19f291c8a471a7da51a6bf7bbb62e1b26adb3/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/hixie/perf/007-expected.png
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/transforms/text-with-mask-with-svg-transform-expected.png
[add] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/svg/zoom/page/zoom-mask-with-percentages-expected.png
[delete] https://crrev.com/89d19f291c8a471a7da51a6bf7bbb62e1b26adb3/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v175/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[add] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/svg/absolute-sized-content-with-resources-expected.png
[add] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/svg/absolute-sized-content-with-resources-expected.txt
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/Source/core/paint/CSSMaskPainter.cpp
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/Source/core/paint/CSSMaskPainterTest.cpp
[modify] https://crrev.com/04e20c3f63e2f9691ccaba746a71b6eb067d0639/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp

Comment 5 by wangxianzhu@chromium.org, Feb 1 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment