Issue metadata
Sign in to add a comment
|
Buttons from open/save dialogs does not respect system language on linux (Gnome)
Reported by
glaube...@live.com,
Jan 30 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36 Steps to reproduce the problem: 1. start Gnome session on any linux distribution 2. open chromium and load any webpage 3. press ctrl+s to open save dialog or ctrl+o to open dialog What is the expected behavior? "save", "open" and "cancel" buttons from open/save dialogs are translated to current system language What went wrong? "open", "save" and "cancel" buttons language is always english despite my system language is pt-br. Compare the screenshots of chromium and firefox showing save dialog on the same system. Did this work before? N/A Chrome version: 64.0.3282.119 Channel: stable OS Version: Arch Linux Flash Version: 28.0.0.137-1 Other chromium-based browsers (Opera and Vivaldi) are also affected. Report about this issue in Gnome bug tracker https://bugzilla.gnome.org/show_bug.cgi?id=786864
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6156302bb51b12fe42fd79283ecce6e655b666a4 commit 6156302bb51b12fe42fd79283ecce6e655b666a4 Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Jan 31 20:27:31 2018 Gtk: Internationalize file chooser dialog buttons CL [1] caused the "Close", "Open", and "Cancel" buttons on file chooser dialogs to always appear in English. The internationalization of the buttons used to be done by GTK using GtkStock, but that has been deprecated since GTK 3.10. The documentation recommends switching out eg. GTK_STOCK_CANCEL with "_Cancel" [2] (the underscore indicates that Alt+(the next character), in this case Alt+C, will take the cancel action). However, this means that the label will always be in English. Chrome could try to internationalize the labels ourselves, but it is not always clear which character the Alt code should correspond to, so this CL switches back to using the deprecated GtkStock API, guarded by some G_GNUC_{BEGIN,END}_IGNORE_DEPRECATIONS. [1] https://crrev.com/c694003c15dc6af21b453febd1463c5394c98c9e [2] https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-CANCEL:CAPS BUG= 807372 R=erg Change-Id: Ie15acc62d48e180cdaf8a852e293a35977aec3d9 Reviewed-on: https://chromium-review.googlesource.com/895864 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#533383} [modify] https://crrev.com/6156302bb51b12fe42fd79283ecce6e655b666a4/chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk.cc
,
Jan 31 2018
Should be fixed in Chrome 66.x.x.x and later
,
Feb 1 2018
Checked the issue on chrome version 66.0.3336.0 using Ubuntu 14.04 with GNOME Flashback(Compiz) Environment. Changed the language to "Hindi" After Ctrl+S we got a pop-up where the UI is not exactly same when compared to the screen shots provided in comment#0. Attaching the screen shot for reference, Where the language of buttons are still in English. @thomasanderson: Could you please let us know if the steps followed for verifying the issue are correct. Thanks!
,
Feb 1 2018
You just set the keyboard layout to Hindi. You need to set it for the entire system. The "Applications" and "Places" in the top-left corner of your screenshot should be in Hindi as well. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by thomasanderson@chromium.org
, Jan 30 2018Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)