New issue
Advanced search Search tips

Issue 807331 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

31.9% regression in media.mobile at 532402:532616

Project Member Reported by dalecurtis@google.com, Jan 30 2018

Issue description

Huuuuge memory increase; ~30mb -> 38mb.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 30 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=807331

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=c4aa92304c3fa8e9b8d9ac6943546be6f2cb4c98a661b2c97ad706ef50e6e1b7


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jan 30 2018

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/12d51c5a840000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 31 2018

Cc: danakj@chromium.org vmp...@chromium.org
Owner: danakj@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12d51c5a840000

Move ownership of software ResourcePool backings into the pool.
By danakj@chromium.org ยท Mon Jan 29 20:15:40 2018
chromium @ 694134e2b295464c965306b2865250cd97173de2

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by danakj@chromium.org, Jan 31 2018

I think this is going to be an accounting change. The memory should be reported by the ResourcePool instead of by the ResourceProvider.

Comment 5 by danakj@chromium.org, Jan 31 2018

ResourcePool says to `AddSuballocation()` on its dumps, with the id from the ResourceProvider, which is no longer reporting anything for software. And the id changed for gpu, disconnecting it, which would I imagine cause us to double-report in the pool and provider.

So we should remove the Suballocation for software, and fix the parent node to match again for gpu.

Comment 6 by danakj@chromium.org, Jan 31 2018

 Issue 807713  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1db4fe55034be340988580d95f52bc029146e539

commit 1db4fe55034be340988580d95f52bc029146e539
Author: danakj <danakj@chromium.org>
Date: Wed Jan 31 22:54:50 2018

Fix memory dumps for ResourcePool.

When ResourcePool owns the resource, don't report the memory as a
suballocation of something in the ResourceProvider.

But when it doesn't then fix the id to point at the ResourceProvider's
dump correctly again, avoiding double counting.

R=ericrk@chromium.org, vmpstr@chromium.org

Bug:  807331 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I0e05a7b5d40ea3bc38694dacb398558a7c3035ea
Reviewed-on: https://chromium-review.googlesource.com/895827
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533457}
[modify] https://crrev.com/1db4fe55034be340988580d95f52bc029146e539/cc/resources/resource_pool.cc
[modify] https://crrev.com/1db4fe55034be340988580d95f52bc029146e539/cc/resources/resource_pool.h

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3740739967a5801f289a41e5260df44edeb0c516

commit 3740739967a5801f289a41e5260df44edeb0c516
Author: danakj <danakj@chromium.org>
Date: Fri Feb 02 16:23:28 2018

Add GUIDs for software resource memory dumps in ResourcePool

As per the comments at
https://chromium-review.googlesource.com/c/chromium/src/+/895806/7/cc/resources/resource_pool.cc#b657
we need to add a GUID so that the resource can be corroborated with the
resource in the gpu process. Otherwise the resource will be double-
counted between processes.

R=ericrk@chromium.org, vmpstr@chromium.org

Bug:  807331 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6f66b31b640c0ba86a65b1d40fd49f4da3dd06a1
Reviewed-on: https://chromium-review.googlesource.com/897992
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534067}
[modify] https://crrev.com/3740739967a5801f289a41e5260df44edeb0c516/cc/resources/resource_pool.cc

Cc: kylec...@chromium.org
Graphs recovered!
https://chromeperf.appspot.com/group_report?bug_id=807331

Status: Fixed (was: Assigned)
Cc: npm@chromium.org
 Issue 808663  has been merged into this issue.

Sign in to add a comment