New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807330 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug
q4



Sign in to add a comment

New Tab Page: Remove unused NTP elements post refresh

Project Member Reported by justincohen@chromium.org, Jan 30 2018

Issue description

Most of the UI logic in NTP controller can go away, especially ntp tab bar logic.
 
Is this for iOS?
Labels: OS-iOS

Comment 3 by zea@chromium.org, Jan 30 2018

Labels: zine-triaged
Also remove reading list collection logic.
Labels: Proj-UIRefresh
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/550fa9dcce07ebd09bf281b0389d07e840b01c09

commit 550fa9dcce07ebd09bf281b0389d07e840b01c09
Author: Justin Cohen <justincohen@google.com>
Date: Tue Sep 18 13:39:49 2018

[ios] Remove old incognito page.

Bug: 807330
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If5a512f4acd9acfa9e606a119686040436436dfd
Reviewed-on: https://chromium-review.googlesource.com/1228514
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592022}
[modify] https://crrev.com/550fa9dcce07ebd09bf281b0389d07e840b01c09/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/550fa9dcce07ebd09bf281b0389d07e840b01c09/ios/chrome/browser/ui/ntp/incognito_view.mm
[modify] https://crrev.com/550fa9dcce07ebd09bf281b0389d07e840b01c09/ios/chrome/browser/ui/ntp/resources/BUILD.gn
[delete] https://crrev.com/a7c0d01386d8ba417f9d3b83dd3a66b13f298538/ios/chrome/browser/ui/ntp/resources/incognito_legacy_icon.imageset/Contents.json
[delete] https://crrev.com/a7c0d01386d8ba417f9d3b83dd3a66b13f298538/ios/chrome/browser/ui/ntp/resources/incognito_legacy_icon.imageset/incognito_legacy_icon.png
[delete] https://crrev.com/a7c0d01386d8ba417f9d3b83dd3a66b13f298538/ios/chrome/browser/ui/ntp/resources/incognito_legacy_icon.imageset/incognito_legacy_icon@2x.png
[delete] https://crrev.com/a7c0d01386d8ba417f9d3b83dd3a66b13f298538/ios/chrome/browser/ui/ntp/resources/incognito_legacy_icon.imageset/incognito_legacy_icon@3x.png

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b9de277d9967b7db6f4cf263928084edc5fda90

commit 3b9de277d9967b7db6f4cf263928084edc5fda90
Author: Justin Cohen <justincohen@google.com>
Date: Tue Sep 18 16:58:02 2018

[ios] Remove pre-UI-refresh NTP files.

Migrates IncognitoViewController and ContentSuggestionsCoordinator into CRWNativeContent.
  - This will change again when removing NTP from native content.

Removes NTPHeaderViewAdapter from content suggestions.

Removes all references to unreachable NTP code, such as NewTabPagePanelProtocol, tab bar
related items, ntp view, the shadow logic, etc.

Bug: 807330
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I714b56b9a8db10462488f5542e14ba6318e8235f
Reviewed-on: https://chromium-review.googlesource.com/1228853
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592079}
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.h
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.h
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller_audience.h
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/first_run/first_run_egtest.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/ntp/incognito_view_controller.h
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/ntp/incognito_view_controller.mm
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_bar.h
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_bar.mm
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_bar_button.h
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_bar_button.mm
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_bar_item.h
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_bar_item.mm
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_bar_unittest.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/ntp/new_tab_page_controller.h
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/ntp/new_tab_page_controller_delegate.h
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/ntp/new_tab_page_header_constants.mm
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_panel_protocol.h
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_panel_protocol.mm
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.h
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_view.h
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/new_tab_page_view.mm
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/ntp_header_view_adapter.h
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_coordinator.h
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/ntp/resources/BUILD.gn
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg.imageset/bookmarks_bar_bg.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg.imageset/bookmarks_bar_bg@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg.imageset/bookmarks_bar_bg@2x~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg.imageset/bookmarks_bar_bg~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg_pressed.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg_pressed.imageset/bookmarks_bar_bg_pressed@2x~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_bg_pressed.imageset/bookmarks_bar_bg_pressed~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_breadcrumb.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_breadcrumb.imageset/bookmarks_bar_breadcrumb.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_breadcrumb.imageset/bookmarks_bar_breadcrumb@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_breadcrumb.imageset/bookmarks_bar_breadcrumb@2x~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_breadcrumb.imageset/bookmarks_bar_breadcrumb~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit.imageset/bookmarks_bar_edit.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit.imageset/bookmarks_bar_edit@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit.imageset/bookmarks_bar_edit@2x~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit.imageset/bookmarks_bar_edit~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_moreshadow.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_moreshadow.imageset/bookmarks_bar_edit_moreshadow.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_moreshadow.imageset/bookmarks_bar_edit_moreshadow@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed.imageset/bookmarks_bar_edit_pressed.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed.imageset/bookmarks_bar_edit_pressed@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed.imageset/bookmarks_bar_edit_pressed@2x~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed.imageset/bookmarks_bar_edit_pressed~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed_moreshadow.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed_moreshadow.imageset/bookmarks_bar_edit_pressed_moreshadow.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_edit_pressed_moreshadow.imageset/bookmarks_bar_edit_pressed_moreshadow@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_left.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_left.imageset/bookmarks_bar_left@2x~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_bar_left.imageset/bookmarks_bar_left~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_button_bg.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_button_bg.imageset/bookmarks_button_bg.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_button_bg.imageset/bookmarks_button_bg@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_button_border.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_button_border.imageset/bookmarks_button_border.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/bookmarks_button_border.imageset/bookmarks_button_border@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/disclosure_open.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/disclosure_open.imageset/disclosure_open.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/disclosure_open.imageset/disclosure_open@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_bookmarks.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_bookmarks.imageset/ntp_bookmarks.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_bookmarks.imageset/ntp_bookmarks@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_bookmarks.imageset/ntp_bookmarks@3x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_bottom_bar_shadow.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_bottom_bar_shadow.imageset/ntp_bottom_bar_shadow.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_bottom_bar_shadow.imageset/ntp_bottom_bar_shadow@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_delete_button.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_delete_button.imageset/ntp_delete_button.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_delete_button.imageset/ntp_delete_button@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_google_search_box.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_google_search_box.imageset/ntp_google_search_box.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_google_search_box.imageset/ntp_google_search_box@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_google_search_box.imageset/ntp_google_search_box@3x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_incognito.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_incognito.imageset/ntp_incognito.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_incognito.imageset/ntp_incognito@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_placeholder_bg.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_placeholder_bg.imageset/ntp_mv_placeholder_bg.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_placeholder_bg.imageset/ntp_mv_placeholder_bg@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_placeholder_bg.imageset/ntp_mv_placeholder_bg@3x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentbar.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentbar.imageset/ntp_mv_recentbar@2x~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentbar.imageset/ntp_mv_recentbar~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentpress.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentpress.imageset/ntp_mv_recentpress@2x~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_recentpress.imageset/ntp_mv_recentpress~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_search.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_search.imageset/ntp_mv_search.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_search.imageset/ntp_mv_search@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_container.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_container.imageset/ntp_mv_thumbnail_container.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_container.imageset/ntp_mv_thumbnail_container@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_container.imageset/ntp_mv_thumbnail_container@3x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_empty.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_empty.imageset/ntp_mv_thumbnail_empty.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_empty.imageset/ntp_mv_thumbnail_empty@2x.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_empty.imageset/ntp_mv_thumbnail_empty@2x~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_thumbnail_empty.imageset/ntp_mv_thumbnail_empty~ipad.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_welcome_favicon.imageset/Contents.json
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_welcome_favicon.imageset/ntp_mv_welcome_favicon.png
[delete] https://crrev.com/4b81b38597ee0a1bdf9a3f1c07b1c5366e62a09c/ios/chrome/browser/ui/ntp/resources/ntp_mv_welcome_favicon.imageset/ntp_mv_welcome_favicon@2x.png
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.mm
[modify] https://crrev.com/3b9de277d9967b7db6f4cf263928084edc5fda90/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a87b4157afaf0783e1ac97da4608894b87e365e

commit 7a87b4157afaf0783e1ac97da4608894b87e365e
Author: Justin Cohen <justincohen@google.com>
Date: Thu Sep 20 13:55:56 2018

[ios] Remove old recent tab tests.

Bug: 807330
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I988192d63f2189524b86c5ccd40f64fe42aebf40
Reviewed-on: https://chromium-review.googlesource.com/1228515
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592782}
[modify] https://crrev.com/7a87b4157afaf0783e1ac97da4608894b87e365e/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_egtest.mm

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e64d3fe3ca2ce1e26b88f65f2980978c968ab33f

commit e64d3fe3ca2ce1e26b88f65f2980978c968ab33f
Author: sczs <sczs@chromium.org>
Date: Thu Sep 20 23:39:47 2018

[ios] Deletes legacy c/b/ui/ntp/recent_tabs files

- Deletes legacy recent_tabs files.
- Modifies recent_tabs_table_coordinator_test to work with the new coordinator.
(Deletes tableVC related asserts, since a coordinator shouldn't be tied to a VC)
- Renames RecentTabsHandsetViewControllerCommand to RecentTabsPresentationDelegate.h
and moves it to its own file.
- Renames LegacyRecentTabsTableViewControllerDelegate to RecentTabsTableViewControllerDelegate.

Bug: 807330
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iea5b2aa8c32bdac7c6f8070cf721d8ad0991962a
Reviewed-on: https://chromium-review.googlesource.com/1235278
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593002}
[modify] https://crrev.com/e64d3fe3ca2ce1e26b88f65f2980978c968ab33f/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/e64d3fe3ca2ce1e26b88f65f2980978c968ab33f/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn
[delete] https://crrev.com/0663980bf2c4f570626981f59d7cfbadd855ba85/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_coordinator.h
[delete] https://crrev.com/0663980bf2c4f570626981f59d7cfbadd855ba85/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_coordinator.mm
[delete] https://crrev.com/0663980bf2c4f570626981f59d7cfbadd855ba85/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.h
[delete] https://crrev.com/0663980bf2c4f570626981f59d7cfbadd855ba85/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.mm
[delete] https://crrev.com/0663980bf2c4f570626981f59d7cfbadd855ba85/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller_delegate.h
[rename] https://crrev.com/e64d3fe3ca2ce1e26b88f65f2980978c968ab33f/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_coordinator_unittest.mm
[delete] https://crrev.com/0663980bf2c4f570626981f59d7cfbadd855ba85/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.h
[delete] https://crrev.com/0663980bf2c4f570626981f59d7cfbadd855ba85/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.mm
[delete] https://crrev.com/0663980bf2c4f570626981f59d7cfbadd855ba85/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.h
[delete] https://crrev.com/0663980bf2c4f570626981f59d7cfbadd855ba85/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.mm
[add] https://crrev.com/e64d3fe3ca2ce1e26b88f65f2980978c968ab33f/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_presentation_delegate.h
[add] https://crrev.com/e64d3fe3ca2ce1e26b88f65f2980978c968ab33f/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller_delegate.h
[modify] https://crrev.com/e64d3fe3ca2ce1e26b88f65f2980978c968ab33f/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
[modify] https://crrev.com/e64d3fe3ca2ce1e26b88f65f2980978c968ab33f/ios/chrome/browser/ui/recent_tabs/recent_tabs_mediator.h
[modify] https://crrev.com/e64d3fe3ca2ce1e26b88f65f2980978c968ab33f/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.h
[modify] https://crrev.com/e64d3fe3ca2ce1e26b88f65f2980978c968ab33f/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/e64d3fe3ca2ce1e26b88f65f2980978c968ab33f/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edcc815c40bf8011d8124274542b6a7d1634d2d2

commit edcc815c40bf8011d8124274542b6a7d1634d2d2
Author: Justin Cohen <justincohen@google.com>
Date: Fri Sep 28 13:41:07 2018

[ios] Remove pre-ui refresh from content suggestions.

Bug: 807330
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iaa0935d3d3c10a5ad80a9cf4e758d84e9af95c3a
Reviewed-on: https://chromium-review.googlesource.com/1249885
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595069}
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/app/startup/setup_debugging.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/google/google_logo_service.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.h
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_footer_item.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_learn_more_item.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils_unittest.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/ntp_home_constant.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
[modify] https://crrev.com/edcc815c40bf8011d8124274542b6a7d1634d2d2/ios/chrome/browser/ui/ntp/new_tab_page_controller.h

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/6d3d645954ccc149d9694e4bdd02c7d106e5219d

commit 6d3d645954ccc149d9694e4bdd02c7d106e5219d
Author: Justin Cohen <justincohen@google.com>
Date: Fri Sep 28 14:36:37 2018

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e

commit d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e
Author: sczs <sczs@chromium.org>
Date: Tue Oct 02 22:46:40 2018

[ios] Moves c/b/ui/ntp/recent_tabs to c/b/ui/recent_tabs

-Moves c/b/ui/ntp/recent_tabs to c/b/ui/recent_tabs
-Some small renaming.


Bug: 807330
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Idd006b4d7872a222aecd2d62b585b1d43ee42b89
Reviewed-on: https://chromium-review.googlesource.com/c/1237528
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596018}
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/ntp/BUILD.gn
[delete] https://crrev.com/fa129e69b5467ca0cdadc0c429a5b769c8419418/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/ntp/recent_tabs/views/BUILD.gn
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/ntp/recent_tabs/views/generic_section_header_view.mm
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/ntp/recent_tabs/views/session_section_header_view.mm
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/ntp/recent_tabs/views/session_tab_data_view.mm
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/BUILD.gn
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/closed_tabs_observer_bridge.h
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/closed_tabs_observer_bridge.mm
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_constants.h
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_constants.mm
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_consumer.h
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator_unittest.mm
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_egtest.mm
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_mediator.h
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_mediator.mm
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_presentation_delegate.h
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.h
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller_delegate.h
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/sessions_sync_user_state.h
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/synced_sessions.h
[rename] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/recent_tabs/synced_sessions.mm
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/tab_grid/tab_grid_egtest_util.mm
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/test/BUILD.gn
[modify] https://crrev.com/d677c800a94e7d311cf43ba9b6aea2ac0ca8f61e/ios/chrome/test/earl_grey/BUILD.gn

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd9cbb30820c769979f2145659f702bd5ca4c291

commit cd9cbb30820c769979f2145659f702bd5ca4c291
Author: sczs <sczs@chromium.org>
Date: Thu Oct 04 01:08:03 2018

[ios] Deletes c/b/ui/ntp/recent_tabs.

Since the legacy recent_tabs and history code
has been deleted these views are no longer being used.


Bug: 807330
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I27af5f605f9088356b2e59566362be53710d45be
Reviewed-on: https://chromium-review.googlesource.com/c/1259425
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596461}
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/OWNERS
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/BUILD.gn
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/disclosure_view.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/disclosure_view.mm
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/generic_section_header_view.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/generic_section_header_view.mm
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/header_of_collapsable_section_protocol.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/panel_bar_view.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/panel_bar_view.mm
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/session_section_header_view.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/session_section_header_view.mm
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/session_tab_data_view.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/session_tab_data_view.mm
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/show_full_history_view.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/show_full_history_view.mm
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_in_progress_view.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_in_progress_view.mm
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_off_view.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_off_view.mm
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_on_no_sessions_view.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_on_no_sessions_view.mm
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/spacers_view.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/spacers_view.mm
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/views_utils.h
[delete] https://crrev.com/ed55781e695bcf41663dcd2887d0a7d971e8eeac/ios/chrome/browser/ui/ntp/recent_tabs/views/views_utils.mm

Sign in to add a comment