Issue metadata
Sign in to add a comment
|
Certain PNG files cut off 50% of the way through loading
Reported by
plane...@gmail.com,
Jan 30 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36 Example URL: http://i.stack.imgur.com/7ih9K.png Steps to reproduce the problem: 1. Update Chrome to latest version 2. Load "Problem" PNG from URL 3. Load "Problem" PNG in another browser to compare. What is the expected behavior? To load the PNG completely. What went wrong? fails to load entire png. cuts off 50% of the image. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes Version before 64.0.3282.119 Does this work in other browsers? Yes Chrome version: 64.0.3282.119 Channel: stable OS Version: 10.0 Flash Version: the png passes integrity check
,
Jan 30 2018
Bisected to a libpng update. https://chromium.googlesource.com/chromium/src/+/f82653a473f8de5fc86d0f2ecc75f6237e61946b
,
Jan 31 2018
scroggo@, Can you please comment on M64 stable blocker priority? How the actual impact is? Thank you!
,
Jan 31 2018
,
Jan 31 2018
I haven't had a chance to debug, so I'm not certain what's going on. If we need a fix urgently, we can always revert the update. (There's another change on top of this that would also need to be reverted.) Looking at the changelog for upstream libpng, I see that the next version "Fix[es a] potential problem with bKGD" [1]. This image has a bKGD chunk, so I'll see whether that is the problem. [1] https://github.com/glennrp/libpng/commit/84e6e3567581e0eb0652193c1e4ab38b3f4a9698
,
Jan 31 2018
I think it's worth reverting the change provided it's "simple". My approach would be to look at how much change is required to fix it properly, and how much change is required to revert it, and choose the easiest for M-64 and M-65. We'll need to justify it to release managers to merge into M-64. Less so for M-65.
,
Jan 31 2018
Might be worth noting that both gimp 2.8.20 and qiv 2.3.1 fail to load the bottom half of the image with the same error message: "IDAT: invalid distance too far back" error.
,
Jan 31 2018
> both gimp 2.8.20 and qiv 2.3.1 fail to load the bottom half of the > image with the same error message Same as each other? Or same as Chromium? Chromium doesn't currently print out warnings from libpng, but the warning I see when I step through with a debugger is IDAT: ADLER32 checksum mismatch I don't know enough about libpng internals to evaluate what it will take to fix, but I've filed https://github.com/glennrp/libpng/issues/202 with upstream. > I think it's worth reverting the change provided it's "simple". Reverting is pretty straightforward; we'll have to revert the change from issue 706134 before we can revert to 1.6.22 (where we were before the update that introduced this bug), but we may be able to reapply that patch.
,
Jan 31 2018
Revert is here: https://chromium-review.googlesource.com/c/chromium/src/+/895830
,
Jan 31 2018
,
Jan 31 2018
Thanks all for quickly taking a look at this. As we decide on what to do, do we know the full impact of how many PNG files this is affecting? I loaded a few random ones and they all seem to be working fine. However, we're only at 10% stable for M64 and the number of reports will probably only increase. Patch(Revert) in #9 looks very risky, and I'm not in favor of accepting this for M64.
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d59d694cd460c08892a2ca1825104ae5260e70ad commit d59d694cd460c08892a2ca1825104ae5260e70ad Author: Leon Scroggins III <scroggo@google.com> Date: Thu Feb 01 00:32:46 2018 Revert to libpng version 1.6.22 Bug: 807324 The latest version has a bug causing certain png files to be cut off. Go back to the prior version where the bug was not present. Also revert a a CL that landed on top of the 1.6.34 update: ======================================================================= Revert "Revert "Revert "libpng: Optimize png_do_expand_palette with NEON.""" This reverts commit 4173576b1600fb51d7166b17009b3a16dcfdddaf. ======================================================================= Revert "Reland "Update libpng to 1.6.34"" This reverts commit f82653a473f8de5fc86d0f2ecc75f6237e61946b. Change-Id: I9e7318c660e16cf2c6f004e89ee7de70b7bd12e2 Reviewed-on: https://chromium-review.googlesource.com/895830 Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by: Leon Scroggins <scroggo@chromium.org> Reviewed-by: Chris Blume <cblume@chromium.org> Commit-Queue: Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#533490} [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/BUILD.gn [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/LICENSE [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/README [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/README.chromium [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/arm/filter_neon.S [delete] https://crrev.com/1573814d1e6f4c772a9f807eab1cd5d3ac394a33/third_party/libpng/arm/palette_neon_intrinsics.c [add] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/contrib/intel/INSTALL [rename] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/contrib/intel/filter_sse2_intrinsics.c [rename] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/contrib/intel/intel_init.c [add] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/contrib/intel/intel_sse.patch [delete] https://crrev.com/1573814d1e6f4c772a9f807eab1cd5d3ac394a33/third_party/libpng/patches/0000-plte.patch [delete] https://crrev.com/1573814d1e6f4c772a9f807eab1cd5d3ac394a33/third_party/libpng/patches/README [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/png.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/png.h [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngconf.h [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngerror.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngget.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pnginfo.h [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngmem.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngpread.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngprefix.h [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngpriv.h [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngread.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngrio.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngrtran.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngrutil.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngset.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngstruct.h [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngtest.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngtrans.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngwio.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngwrite.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngwtran.c [modify] https://crrev.com/d59d694cd460c08892a2ca1825104ae5260e70ad/third_party/libpng/pngwutil.c
,
Feb 1 2018
abdulsyed@, the bug is fixed at ToT, and it sounds like we won't take it for M64. So is it appropriate to mark it as fixed? planet95@, do you know the copyright for the image? It would be great if we could add it (or something that exercises the same bug) to layout tests.
,
Feb 1 2018
How safe is the revert to merge to M65?
,
Feb 1 2018
For the most part, it is very safe - though a lot of files have changed, it brings us back to version 1.6.22, which we were using for a while without any major problems I'm aware of. But this might have broken the MIPS build, because I forgot to revert https://chromium-review.googlesource.com/c/chromium/src/+/830153 (which also was on top of the update to 1.6.34). That CL adds and builds some files from upstream. As I understand it, our version of 1.6.22 was building some version of those files in a different location.
,
Feb 1 2018
@scroggo, image is free to use. I can attach some more if needed.
,
Feb 1 2018
Great, please do. That might be helpful in determining why they are failing. Thanks!
,
Feb 1 2018
the d_ images pass pngcheck validation but still fail to load correctly. mheader_1.png has errors but renders correctly in other browsers.
,
Feb 5 2018
Thank you, planet95@! FYI abdulsyed@, another report in issue 808832 is likely the same bug.
,
Feb 5 2018
,
Feb 5 2018
It turns out that there is a bug in the PNG files themselves. pngfix (distributed with libpng) can be used to fix the images. In addition, we can set a PNG_OPTION that allows supporting the buggy images. According to libpng-manual.txt, "hundreds of PNG files in the wild that have" this same problem, and we used to display them properly, so it seems reasonable to support them. The change is very small, if we want to merge to M64/M65: https://chromium-review.googlesource.com/c/chromium/src/+/901985 For master, I'll upload a CL that relands the libpng update + optimizations.
,
Feb 5 2018
Pls request a merge to M65 once cl is well baked/verified in canary and safe to merge to M65. Thank you.
,
Feb 5 2018
> @scroggo, image is free to use. I can attach some more if needed. planet95@, what is the license on these images? Do they belong to you? How were they created? I'll feel more comfortable committing them to our test code with some more details.
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5daae05a5ffd24dd6b1c9524e155ff848c1a2eb commit a5daae05a5ffd24dd6b1c9524e155ff848c1a2eb Author: Leon Scroggins III <scroggo@google.com> Date: Mon Feb 05 22:27:57 2018 Support pngs with incorrect CMF bytes Bug: 807324 An upgrade to libpng version 1.6.34 resulted in Chromium truncating some pngs. This pngs are technically incorrect, but turning this option on allows displaying them the way we previously did. Change-Id: Ib800486cbf6e28b4df028d5264f6661eda08dc4c Reviewed-on: https://chromium-review.googlesource.com/901985 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Leon Scroggins <scroggo@chromium.org> Commit-Queue: Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#534509} [modify] https://crrev.com/a5daae05a5ffd24dd6b1c9524e155ff848c1a2eb/third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp [modify] https://crrev.com/a5daae05a5ffd24dd6b1c9524e155ff848c1a2eb/third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.h [modify] https://crrev.com/a5daae05a5ffd24dd6b1c9524e155ff848c1a2eb/third_party/libpng/BUILD.gn
,
Feb 6 2018
@scroggo Yes, the images belong to and were created by me and are free to use for testing. They were created with a service using: https://web.archive.org/web/20150713083602/http://efflare.com/products/cfx_imageflare/
,
Feb 6 2018
Verified the fix on M66 66.0.3341.0 on Mac 10.13.1,Windows 10 and Ubuntu 14.04 and fix is working as intended. i.e; We are able to see the image properly with out any issues. Attaching the screenshot for reference. As the fix is working as intended adding Verified labels. Thanks!
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9030625190ec0a2b60be2af279bcb234f47d3f51 commit 9030625190ec0a2b60be2af279bcb234f47d3f51 Author: Leon Scroggins III <scroggo@google.com> Date: Tue Feb 06 15:24:47 2018 Add a regression test for libpng upgrade Bug: 807324 Without the proper fix, this image is truncated. Test that it is not. This image was posted to the bug (as d_AppReq.png), and the owner has given permission to use it: https://bugs.chromium.org/p/chromium/issues/detail?id=807324#c25 Change-Id: I114017e3cc625e0ac6c69056e34b0ee1ad906bb0 Reviewed-on: https://chromium-review.googlesource.com/904262 Reviewed-by: Leon Scroggins <scroggo@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#534690} [add] https://crrev.com/9030625190ec0a2b60be2af279bcb234f47d3f51/third_party/WebKit/LayoutTests/images/resources/crbug807324.png [modify] https://crrev.com/9030625190ec0a2b60be2af279bcb234f47d3f51/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoderTest.cpp
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7b9a0fe6a75507cd007920762d008941edfc182 commit b7b9a0fe6a75507cd007920762d008941edfc182 Author: Leon Scroggins III <scroggo@google.com> Date: Tue Feb 06 19:12:06 2018 Reland update to libpng 1.6.34 with optimizations Bug: 807324 Bug: 808665 An upgrade to libpng version 1.6.34 resulted in Chromium truncating some pngs. This pngs are technically incorrect, but according to libpng-manual.txt, "hundreds of PNG files in the wild that have" this error, and we previously displayed them properly, so we should continue to do so. That bug is fixed with crrev.com/c/901985, which is safe to land prior to the (re-)upgrade. crrev.com/c/904262 is a regression test that will ensure that this does not re-break these images. Along with that fix, revert d59d694cd460c08892a2ca1825104ae5260e70ad, taking us back to 1.6.34 along with the arm optimizations that were reverted in that commit. Change-Id: I9ee925e25d94d1ba0d27fb9ba65abf9606f13828 Reviewed-on: https://chromium-review.googlesource.com/902145 Reviewed-by: Leon Scroggins <scroggo@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#534744} [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/BUILD.gn [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/LICENSE [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/README [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/README.chromium [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/arm/filter_neon.S [add] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/arm/palette_neon_intrinsics.c [delete] https://crrev.com/4eacfee49b5de297908060fb9fb6153ff56f720f/third_party/libpng/contrib/intel/INSTALL [delete] https://crrev.com/4eacfee49b5de297908060fb9fb6153ff56f720f/third_party/libpng/contrib/intel/intel_sse.patch [rename] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/intel/filter_sse2_intrinsics.c [rename] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/intel/intel_init.c [add] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/patches/0000-plte.patch [add] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/patches/README [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/png.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/png.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngconf.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngerror.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngget.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pnginfo.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngmem.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngpread.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngprefix.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngpriv.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngread.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngrio.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngrtran.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngrutil.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngset.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngstruct.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngtest.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngtrans.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngwio.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngwrite.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngwtran.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngwutil.c
,
Feb 6 2018
> Pls request a merge to M65 once cl is well baked/verified in canary and safe > to merge to M65. Thank you. govind@, what are the criteria for it being well baked/verified? Should I leave the bug open until we (potentially) merge to M65?
,
Feb 6 2018
Pls update bug with canary result on Thursday. Also which CL you're requesting a merge for? And yes, pls leave the bug open until we (potentially) merge to M65. Thank you.
,
Feb 6 2018
> Pls update bug with canary result on Thursday. Sorry, I'm not very familiar with this :( How can I find the canary result? > Also which CL you're requesting a merge for? https://chromium-review.googlesource.com/901985 > And yes, pls leave the bug open until we (potentially) merge to M65. Thank you. Will do, thanks!
,
Feb 6 2018
Pls update bug with canary result on Thursday : This means pls verify the fix on canary and make sure it doesn't cause any new regression(functional/stability/perf). Thank you.
,
Feb 7 2018
I'm sorry, I'm still not following you. Does this mean I should download a canary build and use it? Or is there a dashboard I can use to see trends in functionality/stability/perf? What is the URL?
,
Feb 7 2018
I am checking this on Canary Desktop now.
,
Feb 7 2018
Thanks!
,
Feb 7 2018
Verified the fix on latest Chrome Canary i.e., 66.0.3342.0 on Windows10, Mac and Linux.
,
Feb 7 2018
Thank you pbommana@ for canary verification. scroggo@, pls request a merge to M65 for this cl - https://chromium-review.googlesource.com/901985. Thank you.
,
Feb 7 2018
,
Feb 7 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 7 2018
Approving merge for https://chromium-review.googlesource.com/901985 to M65 branch 3325 based on comment #36. Please merge ASAP. Thank you.
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30d97614af893554d521326cfca26d1155642bb7 commit 30d97614af893554d521326cfca26d1155642bb7 Author: Leon Scroggins III <scroggo@google.com> Date: Wed Feb 07 19:52:13 2018 Support pngs with incorrect CMF bytes Bug: 807324 An upgrade to libpng version 1.6.34 resulted in Chromium truncating some pngs. This pngs are technically incorrect, but turning this option on allows displaying them the way we previously did. Change-Id: Ib800486cbf6e28b4df028d5264f6661eda08dc4c Reviewed-on: https://chromium-review.googlesource.com/901985 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Leon Scroggins <scroggo@chromium.org> Commit-Queue: Leon Scroggins <scroggo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#534509}(cherry picked from commit a5daae05a5ffd24dd6b1c9524e155ff848c1a2eb) Reviewed-on: https://chromium-review.googlesource.com/907448 Cr-Commit-Position: refs/branch-heads/3325@{#369} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/30d97614af893554d521326cfca26d1155642bb7/third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp [modify] https://crrev.com/30d97614af893554d521326cfca26d1155642bb7/third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.h [modify] https://crrev.com/30d97614af893554d521326cfca26d1155642bb7/third_party/libpng/BUILD.gn
,
Feb 7 2018
,
Feb 8 2018
The NextAction date has arrived: 2018-02-08
,
Feb 10 2018
A bug resolve, a regression test, very nice work Leon.
,
Feb 14 2018
Android: Works as per expected behavior that is its loads complete PNG " HOME" Issue verified on 65.0.3325.74 and 66.0.3347.0
,
Feb 14 2018
Verified the fix on M65 65.0.3325.73 on Mac 10.13.1,Windows 10 and Ubuntu 14.04 and fix is working as intended. i.e; We are able to see the image properly with out any issues. Attaching the screenshot for reference. Note: Able to reproduce the issue on reported chrome version 64.0.3282.119. As the fix is working as intended adding Verified labels. Thanks!
,
Feb 14 2018
Verified in Android -65.0.3325.74 build
,
Feb 21 2018
Issue 814220 has been merged into this issue.
,
Feb 28 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/9e8a594905316d14aeb55ab5ab5f50e03cb847c6 commit 9e8a594905316d14aeb55ab5ab5f50e03cb847c6 Author: Leon Scroggins III <scroggo@google.com> Date: Wed Feb 28 21:46:03 2018 Support pngs with incorrect CMF bytes Bug: chromium:807324 Though these pngs are technically incorrect, many such PNGs exist, and they are supported in Chromium. Ensure that users of SkCodec (e.g. Android, Flutter) display them as well. Change-Id: I2f1e573b4b7039cea81f96397cc0aa4cbc9461c3 Reviewed-on: https://skia-review.googlesource.com/111082 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> [modify] https://crrev.com/9e8a594905316d14aeb55ab5ab5f50e03cb847c6/third_party/libpng/BUILD.gn [add] https://crrev.com/9e8a594905316d14aeb55ab5ab5f50e03cb847c6/resources/images/crbug807324.png [modify] https://crrev.com/9e8a594905316d14aeb55ab5ab5f50e03cb847c6/src/codec/SkPngCodec.cpp [modify] https://crrev.com/9e8a594905316d14aeb55ab5ab5f50e03cb847c6/tests/CodecTest.cpp
,
Mar 1 2018
Issue 817265 has been merged into this issue.
,
Mar 5 2018
So the fix won't get merged into M64 giving M65 is only a few days away? Issue 817265 can still be reproduced on 64.0.3282.186.
,
Mar 8 2018
Verified the fix in current stable Google Chrome 65.0.3325.146 (Official Build) (64-bit) Revision f926414266f7aecb5ec1bf1b5f93f8716976ceef-refs/branch-heads/3325@{#669} OS Linux
,
Mar 12 2018
Verified the fix on Chrome 65.0.3325.153/CrOS 10323.54.0 - Clapper |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Jan 30 2018