Mixing overflow and columns causing incorrect rendering, new in Chrome 64
Reported by
dwbi...@gmail.com,
Jan 30 2018
|
|||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36 Example URL: https://jsfiddle.net/acfc55e4/1/ Steps to reproduce the problem: 1. View a webpage containing an overflow: scroll element is contains an element with columns 2. Adjust view until content disappears or is clipped. What is the expected behavior? Content renders. What went wrong? Content is clipped or doesn't render at all. Example bad rendering attached Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes 63 Does this work in other browsers? Yes Chrome version: 64.0.3282.119 Channel: stable OS Version: Flash Version:
,
Jan 30 2018
,
Jan 30 2018
,
Jan 30 2018
I suspect that this is caused by some recent change in paint land, but I'm not able to bisect at the moment.
,
Jan 30 2018
Bisected to: https://chromium.googlesource.com/chromium/src/+log/c9f77bf3e3b255910d644c32fca71b960273865b..844c165fae551c35f0eb78b3fd211739377102a7 Suspecting: https://chromium.googlesource.com/chromium/src/+/844c165fae551c35f0eb78b3fd211739377102a7
,
Jan 31 2018
Able to reproduce the issue on Windows 10 and Ubuntu 14.04 using chrome reported version #64.0.3282.119 and latest canary #66.0.3334.0. Issue is not seen in OS-Mac. Bisect Information: ===================== Good build: 64.0.3272.0 Revision(517671) Bad Build : 64.0.3275.0 Revision(518486) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/d875cacbdc450d8594b560d4511bef1e88c5f01b..4957a2278b0a40e178f6814b15261adf955246ad From the above change log suspecting below change Change-Id: Ic62984310cfbcaa6f6a9de080bbc50c31f9c0433 Reviewed-on: https://chromium-review.googlesource.com/780401 wangxianzhu@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Adding stable blocker for M-64 as it seems to be a recent regression. Please feel free to remove the same if not appropriate. Thanks...!!
,
Jan 31 2018
Reduced test case: <div style="margin-top: 50px; overflow-y: scroll; width: 200px"> <div style="columns: 1">Some text</div> </div>
,
Jan 31 2018
How widespread is this issue? We need to determine if this blocks M64.
,
Jan 31 2018
It looks rare, but I don't have a number for now. We could get the number several hours by running a stat job on cluster telemetry. The fix is simple, safe and easy to verify though: https://chromium-review.googlesource.com/c/chromium/src/+/894699.
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c7ac7ada27c7d4e0d4109d70c18ff78827a6285 commit 8c7ac7ada27c7d4e0d4109d70c18ff78827a6285 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Jan 31 22:09:44 2018 [PE] Correct fragment paint offset under non-self-painting paint_offset_root Bug: 807314 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I635c0d6303894f9aa49197edcbfe6de8990a68b6 Reviewed-on: https://chromium-review.googlesource.com/894699 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#533434} [modify] https://crrev.com/8c7ac7ada27c7d4e0d4109d70c18ff78827a6285/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/8c7ac7ada27c7d4e0d4109d70c18ff78827a6285/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
,
Feb 1 2018
Building 32d4ddde7d92f049d163642e57b04a040a015a62 fixes this for me. Thank you -impressively fast response!
,
Feb 2 2018
Stat results show that 4 of top 10k, 22 of top 100k web pages are affected by this bug. Seems a borderline case for blocking stable, but the fix is simple and safe. Verified on ToT build. Will request merge to M64 and M65 after this is baked into a canary build.
,
Feb 5 2018
Baked in 66.0.3337+. Verified on ToT on Linux.
,
Feb 6 2018
+ Chrome-OS Can we target this fix to M-65 if it's not widely spread in M64??
,
Feb 6 2018
,
Feb 6 2018
OK. I think this bug affects all platforms using blink, while perhaps not on HighDPI machines.
,
Feb 6 2018
How safe is this fix? Are there chances of introducing any new regressions?
,
Feb 6 2018
It's safe. Currently I don't see any chance of new regression.
,
Feb 7 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 7 2018
Pls merge your change to M65 branch 3325 before 2:00 PM PT tomorrow, Wednesday (02/07/18). Thank you.
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31d4c5fac2404819011fc93aab1606f42745897d commit 31d4c5fac2404819011fc93aab1606f42745897d Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Feb 07 02:32:59 2018 [PE] Correct fragment paint offset under non-self-painting paint_offset_root TBR=wangxianzhu@chromium.org (cherry picked from commit 8c7ac7ada27c7d4e0d4109d70c18ff78827a6285) Bug: 807314 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I635c0d6303894f9aa49197edcbfe6de8990a68b6 Reviewed-on: https://chromium-review.googlesource.com/894699 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#533434} Reviewed-on: https://chromium-review.googlesource.com/905992 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#358} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/31d4c5fac2404819011fc93aab1606f42745897d/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
,
Feb 7 2018
,
Feb 7 2018
+abdulsyed@ (M64 TPM) just in case if he is planning to take this fix in for next M64 respin based on comments #17 & #18.
,
Feb 7 2018
,
Feb 7 2018
There is another report ( bug 809041 ) for M64. I'm adding back Target-64, and adding Merge-Request-64 because this bug has real world impact, and the fix is safe.
,
Feb 7 2018
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 7 2018
Unable to reproduce the issue on 65.0.3325.56/10323.21.0 - Glimmer
,
Feb 7 2018
,
Feb 7 2018
Approving merge for M64. Branch:3282
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c54cc6aa9bcc33a91aa4e6ea19d452150f808828 commit c54cc6aa9bcc33a91aa4e6ea19d452150f808828 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Feb 07 20:51:03 2018 [PE] Correct fragment paint offset under non-self-painting paint_offset_root TBR=wangxianzhu@chromium.org (cherry picked from commit 8c7ac7ada27c7d4e0d4109d70c18ff78827a6285) (cherry picked from commit 31d4c5fac2404819011fc93aab1606f42745897d) Bug: 807314 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I635c0d6303894f9aa49197edcbfe6de8990a68b6 Reviewed-on: https://chromium-review.googlesource.com/894699 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#533434} Reviewed-on: https://chromium-review.googlesource.com/905992 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3325@{#358} Cr-Original-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} Reviewed-on: https://chromium-review.googlesource.com/907187 Cr-Commit-Position: refs/branch-heads/3282@{#657} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/c54cc6aa9bcc33a91aa4e6ea19d452150f808828/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
,
Feb 13 2018
,
Feb 13 2018
Verified the fix on Windows-10, Ubuntu 14.04, Mac 10.12.6 on Chrome version #64.0.3282.167 as per the comment#30 Attaching screen shot for reference. Observed "Able to see the content" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
Feb 13 2018
,
Feb 14 2018
Android: Content renders as per expected behavior, Issue verified on 65.0.3325.74
,
Feb 14 2018
Able to reproduce the issue on chrome reported version 64.0.3282.119 Verified the fix on Windows-10, Ubuntu 14.04, Mac 10.12.6 on Chrome version #65.0.3325.73 as per the comment#30 Attaching screen shot for reference. Observed "Able to see the content" Hence, the fix is working as expected. Adding the verified label. Thanks! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Jan 30 2018