Put search ActionView (X) on right side for big screens |
||
Issue descriptionChrome Version: 66 OS: Android What steps will reproduce the problem? (1) Enable #password-search flag at chrome://flags (2) Navigate to Settings > Save Passwords on a tablet (3) Click the search icon What is the expected result? The (X) button to clear the search should be on the right side. What happens instead? The (X) button is on the left side, right next to the very small input field.
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb78c9a80e97a2e1862c30e9371c4345da97d4de commit eb78c9a80e97a2e1862c30e9371c4345da97d4de Author: Friedrich Horschig <fhorschig@chromium.org> Date: Mon Feb 12 12:40:45 2018 Fix the password search icon and view layout The "ifRoom" property doesn't work properly with action views as the main item will not collapse in that case and just move the option to the settings menu. Using "always" (like Site Settings does it) fixes that issue. Removing the previously used "collapseActionView" prevents filling the entire action bar which fixes layouting on large screens. All other changes ensure no regressions although we now have to rely on different Listener methods and UI interaction flows. Bug: 809014 , 807303 Change-Id: I63a07b8b91077e33c50e4859889474d072cb7c94 Reviewed-on: https://chromium-review.googlesource.com/909217 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#536065} [modify] https://crrev.com/eb78c9a80e97a2e1862c30e9371c4345da97d4de/chrome/android/java/res/menu/save_password_preferences_action_bar_menu.xml [modify] https://crrev.com/eb78c9a80e97a2e1862c30e9371c4345da97d4de/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java [modify] https://crrev.com/eb78c9a80e97a2e1862c30e9371c4345da97d4de/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java
,
Feb 12 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by fhorschig@chromium.org
, Jan 30 2018