Remove "Passwords appear here" during search if user has saved passwords |
|||
Issue descriptionChrome Version: 66 OS: Android What steps will reproduce the problem? (1) Enable #password-search flag at chrome://flags (2) Navigate to Settings > Save Passwords (3) Ensure the password list is not empty (4) Click the search icon & enter a query without match What is the expected result? The results list should be empty - just a blank screen should be shown. What happens instead? "Saved passwords will appear here." is displayed which is confusing if the user had stored passwords already.
,
Jan 30 2018
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7adb5892b621157e3d14055c807429dfbd6a809 commit b7adb5892b621157e3d14055c807429dfbd6a809 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Wed Jan 31 09:19:07 2018 Empty the passwords search results completely This CL completely drops all UI elements that previously popped back in when the results are empty. Reason being, that 1. the link would redirect the user to the same passwords that are synced to the device they are using right now. 2. the "Saved passwords appear here" text would indicate that the user hasn't saved any passwords yet which is not correct. (Another text is not necessary as the interaction with the search field should give enough context for the empty list). Bug: 807300 , 807302 Change-Id: Ice2dab3a5f6ee280a33ef559d540cc0ca6e082cc Reviewed-on: https://chromium-review.googlesource.com/894002 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533237} [modify] https://crrev.com/b7adb5892b621157e3d14055c807429dfbd6a809/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java [modify] https://crrev.com/b7adb5892b621157e3d14055c807429dfbd6a809/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java
,
Jan 31 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by fhorschig@chromium.org
, Jan 30 2018