New issue
Advanced search Search tips

Issue 807298 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in cc::PlaybackImageProvider::GetDecodedDrawImage

Project Member Reported by ClusterFuzz, Jan 30 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6212986210091008

Fuzzer: inferno_canvas_wrecker
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x61300009b700
Crash State:
  cc::PlaybackImageProvider::GetDecodedDrawImage
  cc::DrawImageRectOp::RasterWithFlags
  cc::SkiaPaintCanvas::drawImageRect
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=532705:532746

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6212986210091008

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Components: Internals>GPU
Project Member

Comment 2 by ClusterFuzz, Jan 30 2018

Labels: OS-Windows
Project Member

Comment 3 by ClusterFuzz, Jan 30 2018

Components: Internals>Compositing>Rasterization
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 4 by ClusterFuzz, Jan 30 2018

Labels: Test-Predator-Auto-Owner
Owner: yutak@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/c32b18d4361a2a2aa27ce70fbc78c771930c3caf (Make WebTaskRunner an alias to base::SingleThreadTaskRunner.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 5 by palmer@chromium.org, Jan 30 2018

Cc: danakj@chromium.org vmp...@chromium.org enne@chromium.org
Labels: M-65 Pri-1
Are we sure this bug affects only Windows and macOS?
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 31 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 31 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by danakj@chromium.org, Jan 31 2018

> Are we sure this bug affects only Windows and macOS?

Probably all platforms, this isn't OS-specific code.

Comment 9 by yutak@chromium.org, Feb 1 2018

Labels: Test-Predator-Wrong-CLs
Owner: ----
Status: Untriaged (was: Assigned)
Owner: danakj@chromium.org
Status: Assigned (was: Untriaged)
danakj: could you please help triage/find an owner? Thanks
Owner: enne@chromium.org

Comment 12 by enne@chromium.org, Feb 1 2018

Cc: ericrk@chromium.org
Owner: khushals...@chromium.org
This looks like lifetime issues with the CanvasResourceProvider::ImageDecodeCache in Blink when a canvas gets upgraded from software to accelerated.

Sending over to Khushal.
Mergedinto: 806629
Status: Duplicate (was: Assigned)
Project Member

Comment 14 by ClusterFuzz, Feb 2 2018

ClusterFuzz has detected this issue as fixed in range 533758:533823.

Detailed report: https://clusterfuzz.com/testcase?key=6212986210091008

Fuzzer: inferno_canvas_wrecker
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x61300009b700
Crash State:
  cc::PlaybackImageProvider::GetDecodedDrawImage
  cc::DrawImageRectOp::RasterWithFlags
  cc::SkiaPaintCanvas::drawImageRect
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=532705:532746
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=533758:533823

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6212986210091008

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 15 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Beta Security_Impact-Stable
Project Member

Comment 16 by sheriffbot@chromium.org, May 11 2018

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment