New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 807294 link

Starred by 1 user
Status: Verified
Owner:
pgangishetty@chromium.org
Closed: Feb 2018
Cc:
pgangishetty@chromium.org
matthewjoseph@chromium.org
ka...@chromium.org
█ kbleicher@chromium.org
sontis@chromium.org
█ patricia@chromium.org
dchan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

platform_ExternalUsbPeripherals tests are failing after CL 884575

Project Member Reported by matthewjoseph@chromium.org, Jan 30 2018 
All external peripherals tests are failing to detect the new c-media headphones.

Stainless link to the failures:
https://stainless.corp.google.com/search?view=list&first_date=2018-01-01&last_date=2018-01-30&suite=usb_detect&test=platform_ExternalUsbPeripherals&build=R65&status=FAIL&status=ERROR&status=ABORT&exclude_cts=false&exclude_not_run=false&exclude_non_release=false&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=true

Original CL: https://chromium-review.googlesource.com/884575

Failures reported: ['STEP 1.1. LOGIN FAILS - Not detecting "Microsoft Corp.|C-Media Electronics, Inc. Audio Adapter" - 60 sec', 'STEP 1.5. PLUG FAILS - Not detecting "Microsoft Corp.|C-Media Electronics, Inc. Audio Adapter" - 60 sec']

Possible fix:

Change usb_list = ["\"Kingston Technology Company Inc.\"",
                "\"Alcor Micro Corp.\"",
                "\"USB PnP Sound Device: USB Audio|C-Media Electronics, Inc. Audio Adapter\"",

to: usb_list = ["\"Kingston Technology Company Inc.\"",
                "\"Alcor Micro Corp.\"",
                "\"USB PnP Sound Device: USB Audio|C-Media Electronics, Inc. CM108 Audio\"",

Comment 1 by ka...@chromium.org, Jan 30 2018

Owner: pgangishetty@chromium.org
I see two problems:
1) why the failed string is "C-Media Electronics, Inc. Audio Adapter", as the 'Adapter' substring was removed in this CL.

2) The substring 'CM108' is not being reflected in the regexp matching string.

Last line should be either
"\"USB PnP Sound Device: USB Audio|C-Media Electronics, Inc.\"", which is the common main string
OR
"\"USB PnP Sound Device: USB Audio|C-Media Electronics, Inc.* Audio\"", which is the common regexp string

Comment 2 by matthewjoseph@chromium.org, Jan 30 2018 

We could always modify the regex to include a capture group like this:
    grep -E "USB PnP Sound Device: USB Audio|C-Media Electronics, Inc.* (CM108 Audio Controller|Audio Adapter)"

Testing against both of the below outputs of lsusb returns:

mjn@:[~/bin/python/test] $ cat lu2.txt | grep -E "Microsoft Corp.|C-Media Electronics, Inc.* (CM108 Audio Controller|Audio Adapter)"
Bus 001 Device 019: ID 0d8c:000c C-Media Electronics, Inc. Audio Adapter

mjn@:[~/bin/python/test] $ cat lu1.txt | grep -E "Microsoft Corp.|C-Media Electronics, Inc.* (CM108 Audio Controller|Audio Adapter)"
Bus 001 Device 013: ID 0d8c:013c C-Media Electronics, Inc. CM108 Audio Controller

lu1.txt:
Bus 001 Device 009: ID 04f2:0939 Chicony Electronics Co., Ltd 
Bus 001 Device 008: ID 0bda:0306 Realtek Semiconductor Corp. 
Bus 001 Device 006: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter
Bus 001 Device 013: ID 0d8c:013c C-Media Electronics, Inc. CM108 Audio Controller
Bus 001 Device 012: ID 13fe:5500 Kingston Technology Company Inc. 
Bus 001 Device 011: ID 058f:3832 Alcor Micro Corp. 
Bus 001 Device 010: ID 1a40:0101 Terminus Technology Inc. Hub
Bus 001 Device 007: ID 1a40:0101 Terminus Technology Inc. Hub
Bus 006 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 005 Device 002: ID 2232:1056 Silicon Motion 
Bus 005 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 003 Device 002: ID 0b95:7720 ASIX Electronics Corp. AX88772
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 005: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

lu2.txt
Bus 001 Device 011: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter
Bus 001 Device 022: ID 058f:3841 Alcor Micro Corp. 
Bus 001 Device 021: ID 13fe:5500 Kingston Technology Company Inc. 
Bus 001 Device 004: ID 05ac:1402 Apple, Inc. Ethernet Adapter [A1277]
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 020: ID 1a40:0101 Terminus Technology Inc. Hub
Bus 001 Device 019: ID 0d8c:000c C-Media Electronics, Inc. Audio Adapter
Bus 001 Device 018: ID 1a40:0101 Terminus Technology Inc. Hub
Bus 001 Device 010: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub
Bus 001 Device 017: ID 18d1:5014 Google Inc. 
Bus 001 Device 005: ID 8087:0a2a Intel Corp. 
Bus 001 Device 003: ID 0bda:564b Realtek Semiconductor Corp. 
Bus 001 Device 002: ID 1a40:0101 Terminus Technology Inc. Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

Comment 3 by ka...@chromium.org, Jan 30 2018 

Yes, we can do that too, though little longer.

Comment 4 by pgangishetty@chromium.org, Jan 30 2018

Status: Started (was: Untriaged)

Comment 5 by pgangishetty@chromium.org, Jan 30 2018 


Updated the string to: "\"USB PnP Sound Device: USB Audio|C-Media Electronics, Inc.* Audio\"",  and ran tests locally on below hosts and the test(platform_ExternalUsbPeripherals.detect.login_unplug_plug) had passed:


Sentry: chromeos1-row2-rack5-host6 -(New iMicro USB headphones)

-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/tmp/test_that_results_QodVRa/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug                                                                                [  PASSED  ]
/tmp/test_that_results_QodVRa/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug                       [  PASSED  ]
/tmp/test_that_results_QodVRa/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug/camera_V4L2           [  PASSED  ]
/tmp/test_that_results_QodVRa/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug/desktopui_SimpleLogin [  PASSED  ]
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Total PASS: 4/4 (100%)


Link: chromeos1-row1-rack3-host3 - (Old iMicro USB headphones)

-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/tmp/test_that_results_CXGsLv/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug                                                                                [  PASSED  ]
/tmp/test_that_results_CXGsLv/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug                       [  PASSED  ]
/tmp/test_that_results_CXGsLv/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug/camera_V4L2           [  PASSED  ]
/tmp/test_that_results_CXGsLv/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug/desktopui_SimpleLogin [  PASSED  ]
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Total PASS: 4/4 (100%)


Panther: chromeos1-row2-rack4-host4 - (Old iMicro USB headphones)


-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/tmp/test_that_results_oWcMQQ/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug                                                                                [  PASSED  ]
/tmp/test_that_results_oWcMQQ/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug                       [  PASSED  ]
/tmp/test_that_results_oWcMQQ/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug/camera_V4L2           [  PASSED  ]
/tmp/test_that_results_oWcMQQ/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug/desktopui_SimpleLogin [  PASSED  ]
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Total PASS: 4/4 (100%)


Chell: chromeos1-row2-rack4-host5 - (New iMicro Headphones)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/tmp/test_that_results_Co_lqv/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug                                                                                [  PASSED  ]
/tmp/test_that_results_Co_lqv/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug                       [  PASSED  ]
/tmp/test_that_results_Co_lqv/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug/camera_V4L2           [  PASSED  ]
/tmp/test_that_results_Co_lqv/results-1-platform_ExternalUsbPeripherals.detect.login_unplug_plug/platform_ExternalUsbPeripherals.detect.login_unplug_plug/desktopui_SimpleLogin [  PASSED  ]
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Total PASS: 4/4 (100%)

Will submit the CL with this change.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/671f8b5769cd67d57e9c04c4f70dd5c620cf7702

commit 671f8b5769cd67d57e9c04c4f70dd5c620cf7702
Author: Prasanthi Gangishetty <pgangishetty@chromium.org>
Date: Wed Jan 31 11:36:29 2018

Updated Usb_List

BUG= chromium:807294 
TEST=Tested against some lab DUTs

Change-Id: I4d3c5217f0eb0eb3f5a94c2e4a5687b7b9c62b91
Reviewed-on: https://chromium-review.googlesource.com/894731
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: PRASANTHI GANGISHETTY <pgangishetty@google.com>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_plug
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.unplug_login_plug
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_suspend_unplug_resume_plug
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_closelid_openlid
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_suspend_resume_plug
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_suspend_plug_resume
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.usb_detect.crashes
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_suspend_resume
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_closelid_plug_openlid
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.reboot_login
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_closelid_unplug_openlid_plug
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.unplug_plug
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_closelid_openlid_plug
[modify] https://crrev.com/671f8b5769cd67d57e9c04c4f70dd5c620cf7702/server/site_tests/platform_ExternalUsbPeripherals/control.detect

Comment 7 by pgangishetty@chromium.org, Feb 1 2018

Status: Fixed (was: Started)
CL landed in build 66/10360.0.0

Comment 8 by ka...@chromium.org, Feb 1 2018

Labels: Merge-Request-65 Merge-Request-64
Tests are fixed on ToT - https://screenshot.googleplex.com/FLGSPOmKzyH

Requesting merge to M65 and M64
Project Member

Comment 10 by sheriffbot@chromium.org, Feb 1 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Feb 2 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 6 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/19431ce3665f695eabb6d6791e55963921ba19e2

commit 19431ce3665f695eabb6d6791e55963921ba19e2
Author: Prasanthi Gangishetty <pgangishetty@chromium.org>
Date: Tue Feb 06 18:10:37 2018

Updated Usb_List

BUG= chromium:807294 
TEST=Tested against some lab DUTs

Change-Id: I4d3c5217f0eb0eb3f5a94c2e4a5687b7b9c62b91
Reviewed-on: https://chromium-review.googlesource.com/894731
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: PRASANTHI GANGISHETTY <pgangishetty@google.com>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
(cherry picked from commit 671f8b5769cd67d57e9c04c4f70dd5c620cf7702)
Reviewed-on: https://chromium-review.googlesource.com/904943
Commit-Queue: Kalin Stoyanov <kalin@chromium.org>
Tested-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_plug
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.unplug_login_plug
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_suspend_unplug_resume_plug
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_closelid_openlid
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_suspend_resume_plug
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_suspend_plug_resume
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.usb_detect.crashes
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_suspend_resume
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_closelid_plug_openlid
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.reboot_login
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_closelid_unplug_openlid_plug
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.unplug_plug
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_closelid_openlid_plug
[modify] https://crrev.com/19431ce3665f695eabb6d6791e55963921ba19e2/server/site_tests/platform_ExternalUsbPeripherals/control.detect

Comment 13 by ka...@chromium.org, Feb 6 2018

Cc: kbleicher@chromium.org matthewjoseph@chromium.org
Labels: -Merge-Approved-65
Kevin, can we have this test config changes merge-approved for M64?

Comment 14 by kbleicher@chromium.org, Feb 6 2018 

Re: M64:  This is limited to Google testing configs only?  I'd like to confirm it won't be a modification to the push.

Comment 15 by ka...@chromium.org, Feb 6 2018 

Yes, it is autotest control configuration that is already running good on ToT and I merged to M65. These tests do not run on general lab, but high-touch Cassandra lab limited to TestEng.

Comment 16 by kbleicher@chromium.org, Feb 6 2018

Labels: -Merge-Review-64 Merge-Approved-64
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 6 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f1d1749fdc00ff8d026c059e85c27d52cadbd096

commit f1d1749fdc00ff8d026c059e85c27d52cadbd096
Author: Prasanthi Gangishetty <pgangishetty@chromium.org>
Date: Tue Feb 06 22:20:29 2018

Updated Usb_List

BUG= chromium:807294 
TEST=Tested against some lab DUTs

Change-Id: I4d3c5217f0eb0eb3f5a94c2e4a5687b7b9c62b91
Reviewed-on: https://chromium-review.googlesource.com/894731
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: PRASANTHI GANGISHETTY <pgangishetty@google.com>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
(cherry picked from commit 671f8b5769cd67d57e9c04c4f70dd5c620cf7702)
Reviewed-on: https://chromium-review.googlesource.com/904943
Commit-Queue: Kalin Stoyanov <kalin@chromium.org>
Tested-by: Kalin Stoyanov <kalin@chromium.org>
(cherry picked from commit a4e7c1f4b819f200a76353c46928ebc7cd88d542)
Reviewed-on: https://chromium-review.googlesource.com/905229

[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_plug
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.unplug_login_plug
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_suspend_unplug_resume_plug
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_closelid_openlid
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_suspend_resume_plug
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_suspend_plug_resume
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.usb_detect.crashes
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_suspend_resume
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_closelid_plug_openlid
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.reboot_login
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_closelid_unplug_openlid_plug
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.unplug_plug
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_closelid_openlid_plug
[modify] https://crrev.com/f1d1749fdc00ff8d026c059e85c27d52cadbd096/server/site_tests/platform_ExternalUsbPeripherals/control.detect
Project Member

Comment 19 by sheriffbot@chromium.org, Feb 12 2018 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 20 by ka...@chromium.org, Feb 12 2018

Labels: -Hotlist-Merge-Review -Hotlist-Merge-Approved -Merge-Approved-64 Merge-Merged
►

Sign in to add a comment