New issue
Advanced search Search tips

Issue 807285 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Change the tools menu button

Project Member Reported by gambard@chromium.org, Jan 30 2018

Issue description

The tools menu button should be rotated by 90 degrees. The animation is still the same.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e945bb1f3a0c4d563361b9358532666df955e371

commit e945bb1f3a0c4d563361b9358532666df955e371
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jan 31 10:23:47 2018

Rotate the tools menu button by 90 degrees

This CL rotates the tools menu button (3 dots) by 90 degrees. It also
rotates the animation when an item is added to the reading list.

Bug:  807285 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8553993c8e4b9f38579159087480c1adf82d23e8
Reviewed-on: https://chromium-review.googlesource.com/893360
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533244}
[modify] https://crrev.com/e945bb1f3a0c4d563361b9358532666df955e371/ios/chrome/browser/ui/toolbar/clean/toolbar_tools_menu_button.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61a58b4b756980a978aea64a0ee6413c644c5301

commit 61a58b4b756980a978aea64a0ee6413c644c5301
Author: gambard <gambard@chromium.org>
Date: Mon Feb 05 23:52:40 2018

Update the tools menu button animation

This CL changes the tools menu button such as it is correctly
positionned and the animation is occurring in the right direction in
RTL.

Bug:  807285 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9cfcd86931a22f4b34e6d8a3dfc575afd50f95de
Reviewed-on: https://chromium-review.googlesource.com/899364
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534538}
[modify] https://crrev.com/61a58b4b756980a978aea64a0ee6413c644c5301/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.mm
[modify] https://crrev.com/61a58b4b756980a978aea64a0ee6413c644c5301/ios/chrome/browser/ui/toolbar/clean/toolbar_tools_menu_button.mm

Status: Fixed (was: Assigned)

Sign in to add a comment