New issue
Advanced search Search tips

Issue 807284 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Change the assets of the toolbar buttons.

Project Member Reported by gambard@chromium.org, Jan 30 2018

Issue description

Waiting for assets from UI/UX.
 
NextAction: 2018-02-28
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04251c76635043712cce9ab02d996e9f12320dc5

commit 04251c76635043712cce9ab02d996e9f12320dc5
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Feb 27 17:28:25 2018

Add assets for UI Refresh

This CL adds the new assets to be used for the UI refresh and use them.

Bug:  807284 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6cd1d1132a4552296fdefbcd488652a7cfd59ca2
Reviewed-on: https://chromium-review.googlesource.com/939394
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539482}
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/BUILD.gn
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_dangerous.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_dangerous.imageset/omnibox_connection_dangerous.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_dangerous.imageset/omnibox_connection_dangerous@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_dangerous.imageset/omnibox_connection_dangerous@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_insecure.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_insecure.imageset/omnibox_connection_insecure.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_insecure.imageset/omnibox_connection_insecure@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_insecure.imageset/omnibox_connection_insecure@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_offline.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_offline.imageset/omnibox_connection_offline.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_offline.imageset/omnibox_connection_offline@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_offline.imageset/omnibox_connection_offline@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_secure.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_secure.imageset/omnibox_connection_secure.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_secure.imageset/omnibox_connection_secure@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_connection_secure.imageset/omnibox_connection_secure@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_voice.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_voice.imageset/omnibox_voice.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_voice.imageset/omnibox_voice@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/location_bar/resources/omnibox_voice.imageset/omnibox_voice@3x.png
[modify] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/BUILD.gn
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/BUILD.gn
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_back.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_back.imageset/toolbar_back.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_back.imageset/toolbar_back@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_back.imageset/toolbar_back@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_bookmark.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_bookmark.imageset/toolbar_bookmark.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_bookmark.imageset/toolbar_bookmark@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_bookmark.imageset/toolbar_bookmark@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_bookmark_active.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_bookmark_active.imageset/toolbar_bookmark_active.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_bookmark_active.imageset/toolbar_bookmark_active@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_bookmark_active.imageset/toolbar_bookmark_active@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_forward.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_forward.imageset/toolbar_forward.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_forward.imageset/toolbar_forward@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_forward.imageset/toolbar_forward@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_menu.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_menu.imageset/toolbar_menu.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_menu.imageset/toolbar_menu@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_menu.imageset/toolbar_menu@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_reload.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_reload.imageset/toolbar_reload.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_reload.imageset/toolbar_reload@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_reload.imageset/toolbar_reload@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_search.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_search.imageset/toolbar_search.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_search.imageset/toolbar_search@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_search.imageset/toolbar_search@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_share.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_share.imageset/toolbar_share.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_share.imageset/toolbar_share@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_share.imageset/toolbar_share@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_stop.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_stop.imageset/toolbar_stop.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_stop.imageset/toolbar_stop@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_stop.imageset/toolbar_stop@3x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_switcher.imageset/Contents.json
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_switcher.imageset/toolbar_switcher.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_switcher.imageset/toolbar_switcher@2x.png
[add] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_switcher.imageset/toolbar_switcher@3x.png
[modify] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.h
[modify] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm
[modify] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm
[modify] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.h
[modify] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.mm
[modify] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
[modify] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
[modify] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/public/provider/chrome/browser/images/branded_image_provider.h
[modify] https://crrev.com/04251c76635043712cce9ab02d996e9f12320dc5/ios/public/provider/chrome/browser/images/branded_image_provider.mm

The NextAction date has arrived: 2018-02-28
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70d509b8f34be57f0fab77cff9073d4310ccb387

commit 70d509b8f34be57f0fab77cff9073d4310ccb387
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Feb 28 13:25:14 2018

Update the size of the toolbar

This CL updates the size of the toolbars to match the requirements.
The requirements are described in:  crbug.com/807778 .

Bug:  807284 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icabb8adc10d9b6e4828e83e0b94260612ca334b9
Reviewed-on: https://chromium-review.googlesource.com/939480
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539809}
[modify] https://crrev.com/70d509b8f34be57f0fab77cff9073d4310ccb387/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/70d509b8f34be57f0fab77cff9073d4310ccb387/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/70d509b8f34be57f0fab77cff9073d4310ccb387/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/70d509b8f34be57f0fab77cff9073d4310ccb387/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/70d509b8f34be57f0fab77cff9073d4310ccb387/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm
[modify] https://crrev.com/70d509b8f34be57f0fab77cff9073d4310ccb387/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm
[modify] https://crrev.com/70d509b8f34be57f0fab77cff9073d4310ccb387/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.h
[modify] https://crrev.com/70d509b8f34be57f0fab77cff9073d4310ccb387/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
[modify] https://crrev.com/70d509b8f34be57f0fab77cff9073d4310ccb387/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
[modify] https://crrev.com/70d509b8f34be57f0fab77cff9073d4310ccb387/ios/chrome/browser/ui/toolbar/buttons/toolbar_tab_grid_button.mm
[modify] https://crrev.com/70d509b8f34be57f0fab77cff9073d4310ccb387/ios/chrome/browser/ui/toolbar/buttons/toolbar_tools_menu_button.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1f7d974cacb3a631ce840c13877215e1cb4a31e0

commit 1f7d974cacb3a631ce840c13877215e1cb4a31e0
Author: Gauthier Ambard <gambard@google.com>
Date: Wed Feb 28 15:23:15 2018

Comment 6 by cmasso@google.com, Feb 28 2018

NextAction: 2018-03-14
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7e5bca6f552e8193abf63f62c780e414fd6e6d2

commit c7e5bca6f552e8193abf63f62c780e414fd6e6d2
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Mar 01 16:38:56 2018

Adjust toolbar's blur effect

This CL adjusts the blur effect used by the toolbar to the one requested
in  crbug.com/807778 .
It also adjust the color of the tools menu button to match the one from
the other buttons.

Bug:  807284 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia03bacf8563cf4b0f9a33a1b4e57dff47b67bfbc
Reviewed-on: https://chromium-review.googlesource.com/941441
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540178}
[modify] https://crrev.com/c7e5bca6f552e8193abf63f62c780e414fd6e6d2/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/c7e5bca6f552e8193abf63f62c780e414fd6e6d2/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm
[modify] https://crrev.com/c7e5bca6f552e8193abf63f62c780e414fd6e6d2/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_tints.mm
[modify] https://crrev.com/c7e5bca6f552e8193abf63f62c780e414fd6e6d2/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.h
[modify] https://crrev.com/c7e5bca6f552e8193abf63f62c780e414fd6e6d2/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.mm
[modify] https://crrev.com/c7e5bca6f552e8193abf63f62c780e414fd6e6d2/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
[modify] https://crrev.com/c7e5bca6f552e8193abf63f62c780e414fd6e6d2/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
[modify] https://crrev.com/c7e5bca6f552e8193abf63f62c780e414fd6e6d2/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm

Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-03-14

Comment 10 by cmasso@google.com, Mar 14 2018

NextAction: ----

Sign in to add a comment