Compile error in simulator, uncovered by gcc 4.8 on arm |
||||
Issue descriptionSince https://crrev.com/c/850873, the {SimulatorBase} class has a private static method {VariadicCall}, which is being called by sub-classes (e.g. {Simulator} defined in simulator-arm.h. It should not be possible to call this private method, but most of our compilers just accept this code anyway. GCC4.8 on arm complains, however. This happened on the node build bots. https://crrev.com/c/890449 fixes this by making the method protected. In order to allow node to easily update to the 6.5 branch, we should backmerge this change. Since just one method is changed from private to protected, risk of this merge is minimal.
,
Jan 30 2018
Please add affected OSs.
,
Jan 30 2018
Note that this is a compile error. It happens whenever you compile v8 for arm using gcc 4.8. Not sure how to use the OS label here. It does not matter on which OS you compile.
,
Jan 31 2018
+hablich@ for M65 merge review as this is related to V8.
,
Jan 31 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 31 2018
Merged with https://crrev.com/c/895305 (forgot to reference this issue). |
||||
►
Sign in to add a comment |
||||
Comment 1 by clemensh@chromium.org
, Jan 30 2018