New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 807274 link

Starred by 1 user
Status: Fixed
Owner:
█ c.pa...@samsung.com
Last visit > 30 days ago
Closed: Feb 2018
Cc:
guidou@chromium.org
█ c.pa...@samsung.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Migrate MediaStreamDispatcherHost to be per frame

Project Member Reported by guidou@chromium.org, Jan 30 2018 
Currently, there is only one MediaStreamDispatcherHost per renderer process, but almost all its methods require a frame ID to be supplied by the caller.

This suggests that this object should be per frame, which would lead to some simplifications in its implementations.

Comment 1 by guidou@chromium.org, Jan 30 2018 

c.padhi@: Since you are knowledgeable about this part of the codebase, would you be interested in taking this bug?

Comment 2 by guidou@chromium.org, Jan 30 2018

Cc: guidou@chromium.org
Components: Blink>GetUserMedia

Comment 3 by c.pa...@samsung.com, Jan 31 2018

Owner: c.pa...@samsung.com
Status: Assigned (was: Available)
Yeah, sure.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b33f99608fafbad282ca5eda2f1185e114209b3

commit 2b33f99608fafbad282ca5eda2f1185e114209b3
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Fri Feb 02 06:02:17 2018

Migrate MediaStreamDispatcherHost to be per frame

Currently, there is only one MediaStreamDispatcherHost per renderer
process, but almost all its methods require a frame ID to be supplied
by the caller. This CL migrates this object to be per frame.

Bug:  807274 
Change-Id: I0b7f93e067b789cea5eba020374eb6da243e4890
Reviewed-on: https://chromium-review.googlesource.com/894864
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533970}
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/browser/renderer_host/media/media_stream_dispatcher_host.cc
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/browser/renderer_host/media/media_stream_dispatcher_host.h
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/browser/renderer_host/media/media_stream_manager.h
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/common/media/media_stream.mojom
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/renderer/media/media_stream_device_observer_unittest.cc
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/renderer/media/media_stream_video_capturer_source.cc
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/renderer/media/media_stream_video_capturer_source.h
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/renderer/media/mock_mojo_media_stream_dispatcher_host.cc
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/renderer/media/mock_mojo_media_stream_dispatcher_host.h
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/renderer/media/user_media_processor.cc
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/renderer/media/user_media_processor.h
[modify] https://crrev.com/2b33f99608fafbad282ca5eda2f1185e114209b3/content/renderer/pepper/pepper_media_device_manager.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a

commit cbce7a3b373c3a2d5d587a4ffe54eb710016db4a
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Fri Feb 02 06:07:09 2018

Revert "Migrate MediaStreamDispatcherHost to be per frame"

This reverts commit 2b33f99608fafbad282ca5eda2f1185e114209b3.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Migrate MediaStreamDispatcherHost to be per frame
> 
> Currently, there is only one MediaStreamDispatcherHost per renderer
> process, but almost all its methods require a frame ID to be supplied
> by the caller. This CL migrates this object to be per frame.
> 
> Bug:  807274 
> Change-Id: I0b7f93e067b789cea5eba020374eb6da243e4890
> Reviewed-on: https://chromium-review.googlesource.com/894864
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533970}

TBR=avi@chromium.org,tsepez@chromium.org,c.padhi@samsung.com,guidou@chromium.org

Change-Id: I3b35db7ae519b3b5111b290a8611dff5a2101d76
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  807274 
Reviewed-on: https://chromium-review.googlesource.com/897320
Reviewed-by: Chandan Padhi <c.padhi@samsung.com>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#533971}
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/browser/renderer_host/media/media_stream_dispatcher_host.cc
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/browser/renderer_host/media/media_stream_dispatcher_host.h
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/browser/renderer_host/media/media_stream_manager.h
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/common/media/media_stream.mojom
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/renderer/media/media_stream_device_observer_unittest.cc
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/renderer/media/media_stream_video_capturer_source.cc
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/renderer/media/media_stream_video_capturer_source.h
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/renderer/media/mock_mojo_media_stream_dispatcher_host.cc
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/renderer/media/mock_mojo_media_stream_dispatcher_host.h
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/renderer/media/user_media_processor.cc
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/renderer/media/user_media_processor.h
[modify] https://crrev.com/cbce7a3b373c3a2d5d587a4ffe54eb710016db4a/content/renderer/pepper/pepper_media_device_manager.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/122a3122cf492974c05737ae174614527b20c870

commit 122a3122cf492974c05737ae174614527b20c870
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Fri Feb 02 09:43:05 2018

Reland "Migrate MediaStreamDispatcherHost to be per frame"

This is a reland of 2b33f99608fafbad282ca5eda2f1185e114209b3.

Original change's description:
> Migrate MediaStreamDispatcherHost to be per frame
>
> Currently, there is only one MediaStreamDispatcherHost per renderer
> process, but almost all its methods require a frame ID to be supplied
> by the caller. This CL migrates this object to be per frame.
>
> Bug:  807274 
> Change-Id: I0b7f93e067b789cea5eba020374eb6da243e4890
> Reviewed-on: https://chromium-review.googlesource.com/894864
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533970}

TBR=guidou, avi, tsepez

Bug:  807274 
Change-Id: Idca20b52a27123cabfbbb55fe570c97a582d4e7a
Reviewed-on: https://chromium-review.googlesource.com/897321
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534010}
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/browser/renderer_host/media/media_stream_dispatcher_host.cc
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/browser/renderer_host/media/media_stream_dispatcher_host.h
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/browser/renderer_host/media/media_stream_manager.h
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/common/media/media_stream.mojom
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/renderer/media/media_stream_device_observer_unittest.cc
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/renderer/media/media_stream_video_capturer_source.cc
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/renderer/media/media_stream_video_capturer_source.h
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/renderer/media/mock_mojo_media_stream_dispatcher_host.cc
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/renderer/media/mock_mojo_media_stream_dispatcher_host.h
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/renderer/media/user_media_processor.cc
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/renderer/media/user_media_processor.h
[modify] https://crrev.com/122a3122cf492974c05737ae174614527b20c870/content/renderer/pepper/pepper_media_device_manager.cc

Comment 7 by guidou@chromium.org, Feb 2 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment