Media Engagement: use min visits for score instead of setting to 0 |
|||||
Issue descriptionCurrent score works like this: ``` if (visits < kMinVisits) return 0; return playbacks / visits; ``` We want something that works like this instead: ``` return playbacks / std::max(visits, kMinVisits); ``` This will allow MEI to slowly increase and be used earlier if we know that it will hit the required level when the number of visits will be reached instead of waiting artificially kMinVisits.
,
Jan 30 2018
,
Feb 6 2018
Requesting merge in order to have comparable data between M65 and M66. This is a very small code change.
,
Feb 7 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 7 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 Beta release. Thank you.
,
Feb 7 2018
Merging is unfortunately blocked by bug 810120
,
Feb 7 2018
M65 merge is approved for blocking bug 810120 . Thank you.
,
Feb 8 2018
Re #8, M65 merge is done for blocking bug 810120 . Could you pls do M65 merge for this bug?
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3d827a3b0d46db494037eb710813bba512144fd commit d3d827a3b0d46db494037eb710813bba512144fd Author: Mounir Lamouri <mlamouri@chromium.org> Date: Thu Feb 08 20:08:04 2018 Media Engagement: use min required visits for MEI score when visits is too low. This is allowing us to compute a MEI score during the warm up period and cut down the warmup period if we know that the score would at worse already be high enough. For example, with minimum visits at 10 and MEI threshold at 3, after 3 visits with playback, a website could get MEI privilege instead of waiting for the 7 following visits. Bug: 807268 Change-Id: Id5f65f2d97375ed7507b99925459ab11139c2ae4 Reviewed-on: https://chromium-review.googlesource.com/893263 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#532891}(cherry picked from commit 8390438fe23581433838a2ccd5f088337fb62a2e) Reviewed-on: https://chromium-review.googlesource.com/909369 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#388} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/d3d827a3b0d46db494037eb710813bba512144fd/chrome/browser/media/media_engagement_contents_observer_unittest.cc [modify] https://crrev.com/d3d827a3b0d46db494037eb710813bba512144fd/chrome/browser/media/media_engagement_score.cc [modify] https://crrev.com/d3d827a3b0d46db494037eb710813bba512144fd/chrome/browser/media/media_engagement_score_unittest.cc [modify] https://crrev.com/d3d827a3b0d46db494037eb710813bba512144fd/chrome/browser/media/media_engagement_service_unittest.cc [modify] https://crrev.com/d3d827a3b0d46db494037eb710813bba512144fd/chrome/browser/media/media_engagement_session_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jan 30 2018