Regression : [Devtools] ‘Service worker from..’ section collapse after clicking inside ‘Filter’ text box.
Reported by
avsha...@etouch.net,
Jan 30 2018
|
|||||||||||
Issue descriptionChrome Version : 65.0.3325.31 (Official Build) e78f314d5510b3d61fc4960671e23358931fec96-refs/branch-heads/3325@{#160} 32/64-bit OS : Mac(10.12.6, 10.13.1, 10.13.3), Windows(7,8,8.1,10), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://version page in two different tabs and open devtools in a second tab. 2. In devtools, navigate to ‘Application’ tab and go to ‘Service Workers’ section. 3. Expand ‘Service worker from other domains’ section and click inside ‘Filter’ textbox. 4. Observe. Actual Result : ‘Service worker from other domains’ section collapse after clicking inside ‘Filter’ text box. Expected Result : ‘Service worker from..’ section should not collapse and it should allow user to type inside ‘Filter’ text box. This is a regression issue broken in ‘M-65’ and providing the bisect using ‘per-revision bisect’ script : Good Build : 65.0.3286.0 (revision : 521957) Bad Build : 65.0.3287.0 (revision : 522296) You are probably looking for a change made after 522141 (known good), but no later than 522142 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/3009675f23c9d898168e015c9bed2c9c6f27a099..b76ab6a6b9982ca622a7779733c7009cf1b62aff Suspect : https://chromium.googlesource.com/chromium/src/+/b76ab6a6b9982ca622a7779733c7009cf1b62aff @Eugene : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note : Issue is also reproducible in Canary #66.0.3334.0 build.
,
Jan 30 2018
marking as RBS, please change if required.
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9af875ff294055fc805828d6ab3b5a57a5a5231f commit 9af875ff294055fc805828d6ab3b5a57a5a5231f Author: Eugene Ostroukhov <eostroukhov@chromium.org> Date: Thu Feb 01 18:41:48 2018 DevTools: fix "other service workers" collapsing "other" service workers section should only collapse when the label was clicked. Bug: 807232 Change-Id: Ib048968ed555121c385a176a602a84a00853b152 Reviewed-on: https://chromium-review.googlesource.com/897913 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#533752} [modify] https://crrev.com/9af875ff294055fc805828d6ab3b5a57a5a5231f/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
,
Feb 1 2018
,
Feb 1 2018
,
Feb 1 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 1 2018
,
Feb 1 2018
Removing "Merge-TBD" label as "Merge-Request-65" label is added at #7.
,
Feb 2 2018
,
Feb 2 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 2 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/056c7c9d65c68f5a67235b5dfe8d2b938eb8f25e commit 056c7c9d65c68f5a67235b5dfe8d2b938eb8f25e Author: Eugene Ostroukhov <eostroukhov@chromium.org> Date: Sat Feb 03 03:56:44 2018 DevTools: fix "other service workers" collapsing "other" service workers section should only collapse when the label was clicked. (cherry picked from commit 9af875ff294055fc805828d6ab3b5a57a5a5231f) Bug: 807232 Change-Id: Ib048968ed555121c385a176a602a84a00853b152 Reviewed-on: https://chromium-review.googlesource.com/897913 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#533752} Reviewed-on: https://chromium-review.googlesource.com/900326 Cr-Commit-Position: refs/branch-heads/3325@{#280} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/056c7c9d65c68f5a67235b5dfe8d2b938eb8f25e/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
,
Feb 5 2018
Update : Verified this issue on Mac(10.12.6, 10.13.1, 10.13.4), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS using latest Canary build #66.0.3340.0 and the issue is fixed. Kindly review an attached screen cast. Thank you!
,
Feb 6 2018
Retested above issue on Windows(7,8,8.1,10), Linux(14.04 LTS) & Mac(10.12.6, 10.13.1, 10.13.4) OS using today’s Dev build #65.0.3325.51 and the issue is fixed. The fix is working as intended. Kindly review an attached screen-cast. Thank you! |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by avsha...@etouch.net
, Jan 30 2018