New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 807199 link

Starred by 2 users
Status: WontFix
Owner:
hongchan@chromium.org
Closed: Feb 2018
Cc:
█ viswatej...@techmahindra.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Missing Tests] : The checking underflow in PushPullFIFO.cpp never gets invoked

Project Member Reported by susanjun...@techmahindra.com, Jan 30 2018 
Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
===
https://chromium.googlesource.com/chromium/src.git/+/1b42aab70c61b09bb2d3c6881222dc8df4b98bc2

Ref Bug: 
========
https://bugs.chromium.org/p/chromium/issues/detail?id=801685

Thank You!

Comment 1 by hongchan@chromium.org, Jan 30 2018 

This add TRACE to the code and is not something testable. What test are you expecting from this change?

Comment 2 by hongchan@chromium.org, Feb 1 2018

Labels: Needs-Feedback

Comment 3 by ajha@chromium.org, Feb 2 2018 

If this is not testable then I guess we can close this as Won't Fix. I guess this was requested for tests to avoid regressions in future.

Comment 4 by hongchan@chromium.org, Feb 5 2018

Status: WontFix (was: Assigned)
Closing per #3.
►

Sign in to add a comment