Regression: Hangouts video call disconnects after click on manage button in microphone bubble.
Reported by
aiman.an...@etouch.net,
Jan 30 2018
|
||||||||||
Issue descriptionChrome Version: 65.0.3325.31 (Official Build) Revision e78f314d5510b3d61fc4960671e23358931fec96-refs/branch-heads/3325@{#160} (32/64-bit). OS: Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.3) and Linux(14.04 LTS). Test URL: https://hangouts.google.com/webchat/start What steps will reproduce the problem? 1. Launch chrome, Login with above URL and click on Video Call option. 2. On Video call window, click on microphone icon in omnibox and click on manage. 3. Observe as it navigates to chrome://settings/content/microphone Actual: Unable to navigate to hangouts video call window after clicking on manage button. (Note - Settings page open in current video call window, call is getting disconnected and user needs to make video call again). Expected: After step 2, chrome://settings/content/microphone page should open in a separate window, so that the current call does not get disconnect. (And user should be able to switch between video call and settings window) This is a regression issue, broken in M-65 series, Using the per-revision bisect providing the bisect results, Good Build:65.0.3212.0(Revision:527164) Bad Build:65.0.3213.0(Revision:527467) You are probably looking for a change made after 527378 (known good), but no later than 527379 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/309c9cc01e455c17539b9b31b09ed43a4ef3297b..c8f9ef323c67d6207df5ec0383503653a41ee113 Suspect: https://chromium.googlesource.com/chromium/src/+/c8f9ef323c67d6207df5ec0383503653a41ee113 krb@:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: This issue is also seen on M66 Canary(build #66.0.3334.0). Thank You!
,
Jan 30 2018
marking as RB Beta, please change if required.
,
Jan 30 2018
M65 Beta promotion is coming soon and your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and request a merge to M65 branch 3325 ASAP (merge has to be done latest by this Friday, 02/02 @ 5:00 PM PT). Thank you.
,
Jan 30 2018
I don't know how this change could have caused that, but it did cause a smaller issue, and a patch was merged Jan 23. Still happening?
,
Jan 31 2018
Hi w.r.t comment#4 Retested again on Branch build #65.0.3325.33/65.0.3325.36 and on latest Canary #66.0.3334.0 for Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.3) and Linux(14.04 LTS) and issue is still reproducible. Kindly review the attached screen-cast. Re-bisected the above issue on different OS and getting the same revision range. (https://chromium.googlesource.com/chromium/src/+/c8f9ef323c67d6207df5ec0383503653a41ee113) Thank You!
,
Jan 31 2018
I tried this on a Samsung Chromebook 3 with 65.0.3325.35 and, when I click 'Manage', it produces a new bright blue settings window where I can manage mic and camera permissions. The Hangouts window remains unchanged. You don't appear to be in incognito mode so I'm not sure what's different. My change doesn't distinguish between any desktops. There's a small chance that I can try this today on Linux, but more likely tomorrow. (I'm home sick but trying to remain responsive to important issues.)
,
Jan 31 2018
ToT on Linux demonstrates this behavior. Peter, This is slightly different from 807550, but same idea: SINGLETON used to imply NEW_TAB if not found, not CURRENT_TAB which is what TAB_SWITCH needed. It's really starting to look like these dispositions should deviate. I'll send a CL and you can see how it looks.
,
Feb 2 2018
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc983247c218b60efbf1de5fe3e1f6f12dcaf160 commit cc983247c218b60efbf1de5fe3e1f6f12dcaf160 Author: Kevin Bailey <krb@chromium.org> Date: Sat Feb 03 18:42:24 2018 [browser nav] Have singleton disposition behave differently from switch We had SINGLETON_TAB and SWITCH_TO_TAB dispositions sharing a code path. This change separates them such that singletons only search in the current window for a tab, and fall-back to new-foreground-tab instead of current-tab. Bug: 807171 , 807550 Change-Id: I0fb3bb75806269df0916359d4c89246640241660 Reviewed-on: https://chromium-review.googlesource.com/896745 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534279} [modify] https://crrev.com/cc983247c218b60efbf1de5fe3e1f6f12dcaf160/chrome/browser/ui/browser_navigator.cc [modify] https://crrev.com/cc983247c218b60efbf1de5fe3e1f6f12dcaf160/chrome/browser/ui/browser_navigator_browsertest.cc
,
Feb 5 2018
Update : Retested above issue on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS) OS using latest Canary #66.0.3340.0 and issue is fixed. Now, chrome://settings/content/microphone page opens in separate tab. Kindly review the attached screen-cast. Thank you!
,
Feb 5 2018
krb@, pls request a merge to M65 so we can pick this change for next M65 Dev/Beta release. Thank you.
,
Feb 5 2018
,
Feb 5 2018
Approving merge to M65 branch 3325 based on comment #10. Please merge ASAP. Thank you.
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7e23eff72fe2872f607e27730c41d90ca68cdec commit d7e23eff72fe2872f607e27730c41d90ca68cdec Author: Kevin Bailey <krb@chromium.org> Date: Mon Feb 05 18:55:24 2018 [browser nav] Have singleton disposition behave differently from switch We had SINGLETON_TAB and SWITCH_TO_TAB dispositions sharing a code path. This change separates them such that singletons only search in the current window for a tab, and fall-back to new-foreground-tab instead of current-tab. TBR=krb@chromium.org (cherry picked from commit cc983247c218b60efbf1de5fe3e1f6f12dcaf160) Bug: 807171 , 807550 Change-Id: I0fb3bb75806269df0916359d4c89246640241660 Reviewed-on: https://chromium-review.googlesource.com/896745 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#534279} Reviewed-on: https://chromium-review.googlesource.com/902195 Reviewed-by: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#309} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/d7e23eff72fe2872f607e27730c41d90ca68cdec/chrome/browser/ui/browser_navigator.cc [modify] https://crrev.com/d7e23eff72fe2872f607e27730c41d90ca68cdec/chrome/browser/ui/browser_navigator_browsertest.cc
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4155242a950f88e8f47ac9eae74291ad7d2f718e commit 4155242a950f88e8f47ac9eae74291ad7d2f718e Author: Kevin Bailey <krb@chromium.org> Date: Mon Feb 05 21:17:13 2018 [browser nav] Remove FALLTHROUGH macro ...from GetBrowserAndTabForDisposition(). It's not available in M65. Bug: 807171 , 807550 Change-Id: I8afb8ad2fef03030ed08a41660eaab3b21dbe358 TBR: thestig@chromium.org Reviewed-on: https://chromium-review.googlesource.com/902174 Reviewed-by: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#320} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/4155242a950f88e8f47ac9eae74291ad7d2f718e/chrome/browser/ui/browser_navigator.cc
,
Feb 7 2018
Pls mark this bug as fixed if nothing is pending for M65 & M66. Thank you.
,
Feb 7 2018
Update : Retested above issue on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS) OS using latest Dev #65.0.3325.51 and issue is fixed. Now, chrome://settings/content/microphone page opens in separate tab. Kindly review the attached screen-cast. Thank you!
,
Feb 7 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by aiman.an...@etouch.net
, Jan 30 2018