New issue
Advanced search Search tips

Issue 807165 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: !new_size.IsEmpty() in gles2_cmd_decoder_passthrough.cc

Project Member Reported by ClusterFuzz, Jan 30 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6304798115364864

Fuzzer: libFuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !new_size.IsEmpty() in gles2_cmd_decoder_passthrough.cc
  gpu::gles2::GLES2DecoderPassthroughImpl::EmulatedDefaultFramebuffer::Resize
  gpu::gles2::GLES2DecoderPassthroughImpl::ResizeOffscreenFramebuffer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=532611:532630

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6304798115364864

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 30 2018

Components: Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 30 2018

Labels: Test-Predator-Auto-Owner
Owner: geoffl...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/177df647cdfd5e76e5eae86fdb0d1038e92fac4a (Make sure the offscreen framebuffer is never resized to zero.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/101437a9e1cbfcc1951961cfb16cb4fae772433f

commit 101437a9e1cbfcc1951961cfb16cb4fae772433f
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Feb 01 15:17:33 2018

Protect against overflow when converting resize parameters to gfx::Size.

BUG= 807165 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1b2dec1efcdcdaf682b5f34e1faa233a4e10934b
Reviewed-on: https://chromium-review.googlesource.com/893943
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533665}
[modify] https://crrev.com/101437a9e1cbfcc1951961cfb16cb4fae772433f/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/101437a9e1cbfcc1951961cfb16cb4fae772433f/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/101437a9e1cbfcc1951961cfb16cb4fae772433f/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/101437a9e1cbfcc1951961cfb16cb4fae772433f/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/101437a9e1cbfcc1951961cfb16cb4fae772433f/gpu/command_buffer/tests/gl_offscreen_surface_unittest.cc

Project Member

Comment 4 by ClusterFuzz, Feb 2 2018

ClusterFuzz has detected this issue as fixed in range 533658:533672.

Detailed report: https://clusterfuzz.com/testcase?key=6304798115364864

Fuzzer: libFuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !new_size.IsEmpty() in gles2_cmd_decoder_passthrough.cc
  gpu::gles2::GLES2DecoderPassthroughImpl::EmulatedDefaultFramebuffer::Resize
  gpu::gles2::GLES2DecoderPassthroughImpl::ResizeOffscreenFramebuffer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=532611:532630
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=533658:533672

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6304798115364864

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Feb 2 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6304798115364864 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment