Flaky layouttest: hittesting/inline-with-clip-path.html |
||||
Issue descriptionhittesting/inline-with-clip-path.html is failing according to the flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=inline-with-clip-path.html Assigned to the last person who touched the file.
,
Jan 30 2018
Oops, sending a patch to mark it as flaky has failed... crrev.com/c/892588 is now on the CQ.
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f803600511d845787945aeb1773a71319a548a0a commit f803600511d845787945aeb1773a71319a548a0a Author: Makoto Shimazu <shimazu@chromium.org> Date: Tue Jan 30 07:36:33 2018 Mark hittesting/inline-with-clip-path.html as flaky TBR=schenney@chromium.org Bug: 807159 Change-Id: Id49b4c6e72e8a7226f27c4577195131da699cc36 Reviewed-on: https://chromium-review.googlesource.com/892588 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532804} [modify] https://crrev.com/f803600511d845787945aeb1773a71319a548a0a/third_party/WebKit/LayoutTests/TestExpectations
,
Jan 30 2018
,
Jan 30 2018
Here's a crash sample from the bot: DevTools listening on ws://127.0.0.1:39665/devtools/browser/01d9a141-8f4e-4618-9461-d501dcc4fefd Fontconfig warning: "/etc/fonts/fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf [1:1:0128/014739.990589:FATAL:SVGElementProxy.cpp(45)] Check failed: Lifecycle().GetState() <= DocumentLifecycle::kCompositingClean || Lifecycle().GetState() >= DocumentLifecycle::kPaintClean. #0 0x7f9f1e210cbd base::debug::StackTrace::StackTrace() #1 0x7f9f1e20f0fc base::debug::StackTrace::StackTrace() #2 0x7f9f1e29629a logging::LogMessage::~LogMessage() #3 0x7f9f16aa3eab blink::SVGElementProxy::IdObserver::ContentChanged() #4 0x7f9f16aa3897 blink::SVGElementProxy::ContentChanged() #5 0x7f9f16aa3994 blink::SVGElementProxySet::NotifyContentChanged() #6 0x7f9f167346b0 blink::LayoutSVGResourceContainer::NotifyContentChanged() #7 0x7f9f16734d01 blink::LayoutSVGResourceContainer::MarkAllClientsForInvalidation() #8 0x7f9f16731d33 blink::LayoutSVGResourceClipper::RemoveAllClientsFromCache() #9 0x7f9f16735171 blink::LayoutSVGResourceContainer::MarkForLayoutAndParentResourceInvalidation() #10 0x7f9f1676884f blink::SVGResourcesCache::ClientWillBeRemovedFromTree() #11 0x7f9f16724a51 blink::LayoutSVGContainer::RemoveChild() #12 0x7f9f16540b34 blink::LayoutObject::Remove() #13 0x7f9f16591980 blink::LayoutObject::WillBeDestroyed() #14 0x7f9f1672e89b blink::LayoutSVGModelObject::WillBeDestroyed() #15 0x7f9f16592afd blink::LayoutObject::Destroy() #16 0x7f9f16592ada blink::LayoutObject::DestroyAndCleanupAnonymousWrappers() #17 0x7f9f15c2ca9e blink::Node::DetachLayoutTree() #18 0x7f9f15b3ed9f blink::ContainerNode::DetachLayoutTree() #19 0x7f9f15bccad3 blink::Element::DetachLayoutTree() #20 0x7f9f16a92997 blink::SVGElement::DetachLayoutTree() #21 0x7f9f15b3ed77 blink::ContainerNode::DetachLayoutTree() #22 0x7f9f15bccad3 blink::Element::DetachLayoutTree() #23 0x7f9f16a92997 blink::SVGElement::DetachLayoutTree() #24 0x7f9f15b3ed77 blink::ContainerNode::DetachLayoutTree() #25 0x7f9f15bccad3 blink::Element::DetachLayoutTree() #26 0x7f9f16a92997 blink::SVGElement::DetachLayoutTree() #27 0x7f9f15b3ed77 blink::ContainerNode::DetachLayoutTree() #28 0x7f9f15bccad3 blink::Element::DetachLayoutTree() #29 0x7f9f16a92997 blink::SVGElement::DetachLayoutTree() #30 0x7f9f15b3e325 blink::ContainerNode::RemoveBetween() #31 0x7f9f15b3e771 blink::ContainerNode::RemoveChildren() #32 0x7f9f15c2e4b9 blink::Node::setTextContent() #33 0x7f9f16dc43e9 blink::NodeV8Internal::textContentAttributeSetter() #34 0x7f9f16dc42d6 blink::V8Node::textContentAttributeSetterCallback() #35 0x7f9f17de81b2 v8::internal::FunctionCallbackArguments::Call() #36 0x7f9f17ee2c25 v8::internal::(anonymous namespace)::HandleApiCallHelper<>() #37 0x7f9f17ee147f v8::internal::Builtins::InvokeApiFunction() #38 0x7f9f18464388 v8::internal::Object::SetPropertyWithAccessor() #39 0x7f9f1847c683 v8::internal::Object::SetPropertyInternal() #40 0x7f9f1847c37a v8::internal::Object::SetProperty() #41 0x7f9f18361287 v8::internal::StoreIC::Store() #42 0x7f9f183685a0 v8::internal::__RT_impl_Runtime_StoreIC_Miss() #43 0x2e185de04224 <unknown> I think the intention of the DCHECK is to ensure no content mutation during paint, but we recently added a new pre-paint phase which is in between compositing update and paint. Content mutation is safe during kPrePaintClean thus should be allowed.
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/006fd61c7c9404c13995ec1bb34fdd7645e6f4cd commit 006fd61c7c9404c13995ec1bb34fdd7645e6f4cd Author: Tien-Ren Chen <trchen@chromium.org> Date: Tue Jan 30 23:03:35 2018 [Blink] Content mutation should be allowed during kPrePaintClean The DCHECK in SVGElementProxy::IdObserver::ContentChanged() is too restrictive. The document is only vulnerable to mutation during paint or pre-paint, but should be safe to mutate once the update is done. BUG= 807159 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If9f795e0ac55d204d5f165221af2453b54eda6a5 Reviewed-on: https://chromium-review.googlesource.com/894189 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533060} [modify] https://crrev.com/006fd61c7c9404c13995ec1bb34fdd7645e6f4cd/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/006fd61c7c9404c13995ec1bb34fdd7645e6f4cd/third_party/WebKit/Source/core/svg/SVGElementProxy.cpp
,
May 1 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by shimazu@chromium.org
, Jan 30 2018