New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807158 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 21
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Task

Blocking:
issue 767517



Sign in to add a comment

Get rid of SConstruct for libchrome.

Project Member Reported by hidehiko@chromium.org, Jan 30 2018

Issue description

Currently, we use SConstruct for building libchrome.
It's time to get rid of it. Let's use gn + ninja, instead.

 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libchrome/+/7a71c473304cca1b46fcd3d0ef345b7c22fdcce0

commit 7a71c473304cca1b46fcd3d0ef345b7c22fdcce0
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Feb 07 08:43:48 2018

Remove base-sandbox, which nobody uses.

BUG= chromium:807158 
TEST=Built locally.

Change-Id: I22f1cd84fa10f003038bb5e42d77005715c5add5
Reviewed-on: https://chromium-review.googlesource.com/903207
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/7a71c473304cca1b46fcd3d0ef345b7c22fdcce0/SConstruct

Blocking: 767517
Cc: hashimoto@chromium.org
For the record.

Let's resume this as Eric suggested offline.
Regardless of whether we'll use or not gn for platform2/,
gn is better for libchrome, because we already have some BUILD.gn files in chrome repository.
We should be reuse them with some modification.

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e5a7d50822dcacf39bdf7632b6a1840302bddb40

commit e5a7d50822dcacf39bdf7632b6a1840302bddb40
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Dec 07 06:06:33 2018

Use lib_switch, lib_dir_switch.

In GN files, libs and lib_dirs variables should not have "-l" or "-L"
prefixes respectively, which should be appended by toolchain configuration.

cf)
https://gn.googlesource.com/gn/+/master/docs/reference.md#libs
https://gn.googlesource.com/gn/+/master/docs/reference.md#lib_dirs

BUG= chromium:807158 
TEST=Build.

Change-Id: I64eba6b54d851fad1d047fb02c6799445f6c0828
Reviewed-on: https://chromium-review.googlesource.com/1363650
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/fitpicker/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/libchromeos-ui/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/cros-disks/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/common-mk/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/bootstat/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/tpm2-simulator/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/libtpmcrypto/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/cryptohome/libs/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/debugd/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/cromo/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/libpasswordprovider/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/common-mk/pkg_config.gni
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/crash-reporter/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/hermes/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/dlcservice/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/common-mk/toolchain/BUILD.gn
[add] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/common-mk/pkg-config_wrapper.py
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/login_manager/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/image-burner/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/u2fd/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/authpolicy/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/p2p/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/run_oci/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/shill/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/virtual_file_provider/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/cryptohome/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/oobe_config/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/power_manager/BUILD.gn
[modify] https://crrev.com/e5a7d50822dcacf39bdf7632b6a1840302bddb40/chaps/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/25a5cbf24eda611a7c4a09d69733ef8758f02f28

commit 25a5cbf24eda611a7c4a09d69733ef8758f02f28
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Dec 13 14:43:36 2018

common-mk: Implement generate_pkg_config rule.

BUG= chromium:807158 
TEST=Build.

Change-Id: I286f720b74dbbd73d26f4054477a3f8f8c5791b7
Reviewed-on: https://chromium-review.googlesource.com/1366655
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[add] https://crrev.com/25a5cbf24eda611a7c4a09d69733ef8758f02f28/common-mk/generate-pc.py
[modify] https://crrev.com/25a5cbf24eda611a7c4a09d69733ef8758f02f28/common-mk/pkg_config.gni

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libchrome/+/6ddb2e07a8f13d0a25c4458110b0cbf125a48d7c

commit 6ddb2e07a8f13d0a25c4458110b0cbf125a48d7c
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Dec 13 18:15:11 2018

libchrome: Replace SConstruct by BUILD.gn.

BUG= chromium:807158 
TEST=Built locally.
CQ-DEPEND=CL:1366655

Change-Id: I895dfaa153f19b1bac8e47b75681a17e6735a522
Reviewed-on: https://chromium-review.googlesource.com/1366656
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[delete] https://crrev.com/4c8c3f8780fd63d0cfd4a2adf89909e8666bbccb/SConstruct
[add] https://crrev.com/6ddb2e07a8f13d0a25c4458110b0cbf125a48d7c/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libchrome/+/4941951a83ba810f01efcc0914d59b64171db084

commit 4941951a83ba810f01efcc0914d59b64171db084
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Mon Dec 17 00:26:17 2018

libchrome: Add -Wno-unreachable-code.

During the preparation of SCons -> gn migration for libchrome,
-Wunreachable-code is set by default
https://chromium.git.corp.google.com/chromiumos/platform2/+/8eb370f60f962801a98efce8dd3b3ec84048ebd0
which causes a build failure of libchrome.

BUG= chromium:807158 
TEST=Build locally.

Change-Id: Ic71cb7a94fec1084c7164738268b103f32019e0c
Reviewed-on: https://chromium-review.googlesource.com/1377819
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/4941951a83ba810f01efcc0914d59b64171db084/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libchrome/+/6fea5a4c74e9520452f7a16031a6f7eb206d8a0d

commit 6fea5a4c74e9520452f7a16031a6f7eb206d8a0d
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Dec 18 08:42:55 2018

libchrome: Fix libchrome-test-${BASE_VER} link option.

- Fix the library name.
- Fix not to use thin archive.

BUG= chromium:807158 
TEST=Build locally.

Change-Id: I420e213a4a9f08e1f5147874e0b974e79ae2f357
Reviewed-on: https://chromium-review.googlesource.com/1381011
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/6fea5a4c74e9520452f7a16031a6f7eb206d8a0d/BUILD.gn

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cf65e45c51a11ebd14f39daf0be997f5a0fd90ba

commit cf65e45c51a11ebd14f39daf0be997f5a0fd90ba
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Dec 19 21:03:03 2018

common-mk: Add missing IUSE for libchrome.

BUG= chromium:807158 
TEST=Build tatl libchrome locally.

Change-Id: I05c13ecd281aaa1eda00bee5e0ece80f2aeb22a8
Reviewed-on: https://chromium-review.googlesource.com/1382665
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/cf65e45c51a11ebd14f39daf0be997f5a0fd90ba/common-mk/platform2.py

Status: Fixed (was: Started)
Done.

Sign in to add a comment