New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807152 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner: ----
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

Flaky layouttest: VRDisplay_rAF_fires_with_window_rAF.html

Project Member Reported by shimazu@chromium.org, Jan 30 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67f9887c36cd46aa4b3d481f2ff1bbffcfbcb8c1

commit 67f9887c36cd46aa4b3d481f2ff1bbffcfbcb8c1
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Jan 30 05:15:57 2018

Mark VRDisplay_rAF_fires_with_window_rAF.html as flaky

TBR=klausw@chromium.org

NOTRY=true

Bug:  807152 
Change-Id: Ie6894445c01f5ec0cfc83b2a955a5b9b56979bd3
Reviewed-on: https://chromium-review.googlesource.com/892586
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532766}
[modify] https://crrev.com/67f9887c36cd46aa4b3d481f2ff1bbffcfbcb8c1/third_party/WebKit/LayoutTests/TestExpectations

Cc: klausw@chromium.org
Labels: -Pri-2 -Sheriff-Chromium Test-Disabled Pri-1
Owner: mthiesse@chromium.org
Status: Assigned (was: Available)
Could you please redirect?
Labels: -Pri-1 Pri-2
Not sure why this would be flaky, should see if we can fix, but it's not urgent.

Labels: M-67
Labels: -M-67 M-68
Cc: bajones@chromium.org billorr@chromium.org
Owner: ----
Status: Available (was: Assigned)
Somebody working more closely with webVR/XR able to pick this up?
Cc: offenwanger@chromium.org
Labels: -M-68 M-69
+Anna as well.

I have a couple other issues I'm looking at first, but I could potentially look at this next week.  I don't think this needs to be fixed for M68, since its been around since January.
Took a brief look - for the failures I looked at, it doesn't appear we were flaky from getting callbacks out of order - just flaky because we were a millisecond off on reported time.

My guess is some math rounding error.
for future reference - https://chromium.googlesource.com/chromium/src/+/91c1b85524d974f3b9ca143f4da5695b5448f7a8 changed the timing around the same time this was marked as flaky.


Components: Blink>WebXR
Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: -Blink>WebVR
Mergedinto: 914134
Status: Duplicate (was: Available)

Sign in to add a comment