New issue
Advanced search Search tips

Issue 807148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix UIChromeOSTestSuite Set

Project Member Reported by wutao@chromium.org, Jan 30 2018

Issue description

The UIChromeOSTestSuite will fail some of the unit tests based on views::ViewsTestBase.
In the retries, the tests will pass.

By comparing UIChromeOSTestSuite and ViewsTestSuite, the only difference is that UIChromeOSTestSuite does not init/clear up aura env.

The fix will add codes in Initialize/Shutdown to properly setup the aura env for UIChromeOSTestSuite.


Received signal 11 SEGV_MAPERR 000000000000
#0 0x00000099ac8c base::debug::StackTrace::StackTrace()
#1 0x00000099a801 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f15415c9330 <unknown>
#3 0x000000c51188 gl::init::CreateOffscreenGLSurfaceWithFormat()
#4 0x000000c50b1d gl::init::CreateOffscreenGLSurface()
#5 0x000000e3320c gpu::InProcessCommandBuffer::InitializeOnGpuThread()
#6 0x000000e33cd3 gpu::(anonymous namespace)::RunTaskWithResult<>()
#7 0x000000e3670f _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_17RepeatingCallbackIFN3gpu13ContextResultEvEEEPS5_PNS_13WaitableEventEEJS7_S8_SA_EEEFvvEE3RunEPNS0_13BindStateBaseE
#8 0x0000009eb76f base::debug::TaskAnnotator::RunTask()
#9 0x0000009a5637 base::MessageLoop::RunTask()
#10 0x0000009a5b19 base::MessageLoop::DoWork()
#11 0x0000009a652a base::MessagePumpDefault::Run()
#12 0x0000009b5745 base::RunLoop::Run()
#13 0x0000009d157d base::Thread::ThreadMain()
#14 0x0000009cd1cd base::(anonymous namespace)::ThreadFunc()
#15 0x7f15415c1184 start_thread
#16 0x7f153e71703d clone
  r8: 0000000000000000  r9: 00000d90c795bc80 r10: 000071846f9278b8 r11: 00007f153e7a3150
 r12: 00007f1537244580 r13: 00007f15372444f0 r14: 00007f1537244778 r15: 00007f1537244970
  di: 00000d90c7959aa0  si: 0000000000000000  bp: 00007f1537244570  bx: 0000000000000003
  dx: 0000000001321528  ax: 0000000000000000  cx: 00000000012921b8  sp: 00007f15372444a0
  ip: 0000000000c51188 efl: 0000000000010246 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]

 
Components: Tests
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b80c1b5a1053a00852668e28305fe7a3be1fc1df

commit b80c1b5a1053a00852668e28305fe7a3be1fc1df
Author: wutao <wutao@chromium.org>
Date: Tue Jan 30 18:04:47 2018

cros: Fix UIChromeOSTestSuite.

The UIChromeOSTestSuite will fail some of the unit tests based on
views::ViewsTestBase. In the retries, the tests will pass.

By comparing UIChromeOSTestSuite and ViewsTestSuite, the only difference
is that UIChromeOSTestSuite does not init/clear up aura env.

This cl properly sets up and cleans up the aura env for UIChromeOSTestSuite.

Bug:  807148 
Test: ui_chromeos_unittests
Change-Id: Ife3bae23c2003a6e219764f7483cdff7eb785c72
Reviewed-on: https://chromium-review.googlesource.com/892495
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532944}
[modify] https://crrev.com/b80c1b5a1053a00852668e28305fe7a3be1fc1df/ui/chromeos/run_all_unittests.cc

Comment 4 by wutao@chromium.org, Mar 6 2018

Status: Fixed (was: Assigned)

Sign in to add a comment