New issue
Advanced search Search tips

Issue 807127 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 756312



Sign in to add a comment

Remove script streaming flag

Project Member Reported by falken@chromium.org, Jan 30 2018

Issue description

Since this shipped in stable, we can start removing the non-script streaming code path.
 
Blocking: 756312
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/991ab503d9e42df3c02f1d74a0cad53e39003bbc

commit 991ab503d9e42df3c02f1d74a0cad53e39003bbc
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Jan 30 04:24:50 2018

service worker: Remove VirtualTestSuite script-streaming.

Script streaming has been enabled by default for a while, so this
VirtualTestSuite is not needed.

R=shimazu

Bug:  807127 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ieab88b892935fa2a1e35682f4e1acd99c0f82aa9
Reviewed-on: https://chromium-review.googlesource.com/892538
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532751}
[modify] https://crrev.com/991ab503d9e42df3c02f1d74a0cad53e39003bbc/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/991ab503d9e42df3c02f1d74a0cad53e39003bbc/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/991ab503d9e42df3c02f1d74a0cad53e39003bbc/third_party/WebKit/LayoutTests/LeakExpectations
[modify] https://crrev.com/991ab503d9e42df3c02f1d74a0cad53e39003bbc/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/991ab503d9e42df3c02f1d74a0cad53e39003bbc/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/a685c4e3d4df5830a8f96087daa2686e532be5f1/third_party/WebKit/LayoutTests/platform/linux/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[delete] https://crrev.com/a685c4e3d4df5830a8f96087daa2686e532be5f1/third_party/WebKit/LayoutTests/virtual/service-worker-script-streaming/external/wpt/service-workers/README.txt
[delete] https://crrev.com/a685c4e3d4df5830a8f96087daa2686e532be5f1/third_party/WebKit/LayoutTests/virtual/service-worker-script-streaming/http/tests/fetch/serviceworker-proxied/README.txt
[delete] https://crrev.com/a685c4e3d4df5830a8f96087daa2686e532be5f1/third_party/WebKit/LayoutTests/virtual/service-worker-script-streaming/http/tests/fetch/serviceworker/README.txt
[delete] https://crrev.com/a685c4e3d4df5830a8f96087daa2686e532be5f1/third_party/WebKit/LayoutTests/virtual/service-worker-script-streaming/http/tests/serviceworker/README.txt

Comment 3 by falken@chromium.org, Feb 14 2018

Owner: shimazu@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f922da77b0810c5365bbb7d8519518f053f76bed

commit f922da77b0810c5365bbb7d8519518f053f76bed
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Mon Feb 19 09:21:09 2018

Remove ServiceWorkerScriptStreaming flag

Bug:  807127 
Change-Id: I29dc398b9b2809abc0d2eba7345d00aa03acfc9a
Reviewed-on: https://chromium-review.googlesource.com/920566
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537611}
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/chrome/browser/about_flags.cc
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/content/browser/service_worker/service_worker_script_url_loader_factory.cc
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/content/child/runtime_features.cc
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/content/common/service_worker/service_worker_utils.h
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/content/public/common/content_features.cc
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/content/public/common/content_features.h
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/third_party/WebKit/Source/modules/serviceworkers/WebEmbeddedWorkerImplTest.cpp
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/f922da77b0810c5365bbb7d8519518f053f76bed/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Status: Fixed (was: Assigned)
Removed in 66.0.3352.0
Labels: M-66

Sign in to add a comment