New issue
Advanced search Search tips

Issue 807122 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebKit/PRESUBMIT_test.py is failing due to base::OnceCallback<void()>

Project Member Reported by fergal@chromium.org, Jan 30 2018

Issue description

python ./third_party/WebKit/PRESUBMIT_test.py

In all 3 cases it looks like it's due to "base::OnceCallback<void()>" which is on the disallow list but is whitelisted in the audit script.

I guess we can just move it to the allow list or stop testing it at all since

https://crrev.com/c/807754

says it's allowed everywhere in blink.

Also, why doesn't PRESUBMIT_test.py run automatically?
 

Comment 1 by fergal@chromium.org, Jan 30 2018

Owner: fergal@chromium.org
Status: Fixed (was: Untriaged)
Fixed by https://crrev.com/c/892195 . I will file another bug for running _test.py automatically.

Sign in to add a comment