New issue
Advanced search Search tips

Issue 807109 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Splitscreen divider should resize based on new window constraints

Project Member Reported by mccanny@chromium.org, Jan 30 2018

Issue description

Chrome Version: 66.0.3329.0

What steps will reproduce the problem?
(1) Enter splitscreen
(2) Resize the divider to 2/3 - 1/3 split point
(3) Select files app from overview on 1/3 side

What is the expected result?

When a new window (that supports splitscreen, but has a minimum width/height) is selected from overview to join the split, the splitscreen divider should resize to accommodate the minimum width/height of this new window.

What happens instead?

Files app is forced into a size below it's minimum width, where some features are unusable.
 

Comment 1 by x...@chromium.org, Jan 30 2018

Owner: minch@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by minch@chromium.org, Feb 5 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f49c50b4965f982e8cc64ea29307e7a5100afe3d

commit f49c50b4965f982e8cc64ea29307e7a5100afe3d
Author: MinChen <minch@chromium.org>
Date: Tue Feb 06 20:11:38 2018

splitscreen: Update divider and snapped windows bounds after snapped a new window.

Test: SplitViewControllerTest.DividerPositionWithWindowMinimumSizeOnSnapTest
Bug:  807109 
Change-Id: Ibd8680bc60e0d53c01c33efcc6e38536ef2d924d
Reviewed-on: https://chromium-review.googlesource.com/894628
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534768}
[modify] https://crrev.com/f49c50b4965f982e8cc64ea29307e7a5100afe3d/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/f49c50b4965f982e8cc64ea29307e7a5100afe3d/ash/wm/splitview/split_view_controller_unittest.cc

Comment 4 by minch@chromium.org, Feb 6 2018

Labels: OS-Chrome
Status: Fixed (was: Started)

Sign in to add a comment