New issue
Advanced search Search tips

Issue 807106 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Mar 2018
Cc:
sammiequon@chromium.org
zork@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Splitscreen-polish


Sign in to add a comment

Shelf should be opaque when overview is open in splitscreen.

Project Member Reported by mccanny@chromium.org, Jan 30 2018 
Chrome OS Version: 66.0.3329

What steps will reproduce the problem?
(1) Open overview, drag one window into the split region, release.
(2) Shelf remains transparent

What is the expected result?

Shelf should become opaque on window release as shown in the splitscreen motion spec: go/splitscreen-motion. The shelf should also stay opaque at least until splitscreen is closed.

Comment 1 by mccanny@chromium.org, Feb 13 2018

Components: UI>Shell>WindowManager>Splitscreen

Comment 2 by x...@chromium.org, Mar 8 2018

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf3771f1df1ced327a7a3a34dd3c44e543de9244

commit bf3771f1df1ced327a7a3a34dd3c44e543de9244
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Tue Mar 13 18:21:46 2018

Cros splitscreen - Make the shelf fully opaque when splitscreen is active.

Bug:  807106 
Change-Id: I8ff4939634f919f7566b499985af89960fd6ab09
Reviewed-on: https://chromium-review.googlesource.com/954346
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542861}
[modify] https://crrev.com/bf3771f1df1ced327a7a3a34dd3c44e543de9244/ash/public/cpp/shelf_types.h
[modify] https://crrev.com/bf3771f1df1ced327a7a3a34dd3c44e543de9244/ash/shelf/shelf_background_animator.cc
[modify] https://crrev.com/bf3771f1df1ced327a7a3a34dd3c44e543de9244/ash/shelf/shelf_background_animator_unittest.cc
[modify] https://crrev.com/bf3771f1df1ced327a7a3a34dd3c44e543de9244/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/bf3771f1df1ced327a7a3a34dd3c44e543de9244/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/bf3771f1df1ced327a7a3a34dd3c44e543de9244/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/bf3771f1df1ced327a7a3a34dd3c44e543de9244/ash/shell.cc
[modify] https://crrev.com/bf3771f1df1ced327a7a3a34dd3c44e543de9244/ash/shell.h
[modify] https://crrev.com/bf3771f1df1ced327a7a3a34dd3c44e543de9244/ash/shell_observer.h
[modify] https://crrev.com/bf3771f1df1ced327a7a3a34dd3c44e543de9244/ash/wm/splitview/split_view_controller.cc

Comment 4 by x...@chromium.org, Mar 13 2018

Labels: Merge-Request-66 M-66
Status: Fixed (was: Started)

Comment 5 by abdulsyed@google.com, Mar 13 2018 

Can you please list which OS this impacts?

Comment 6 by x...@chromium.org, Mar 13 2018

Labels: OS-Chrome
Sure. It's only for Chrome OS.
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 14 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 14 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/687e67157b8f44587d76167143bc407066541d33

commit 687e67157b8f44587d76167143bc407066541d33
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Wed Mar 14 18:49:14 2018

[Merge to M66] Cros splitscreen - Make the shelf fully opaque when splitscreen is active.

Bug:  807106 
TBR=xiyuan@chromium.org

(cherry picked from commit bf3771f1df1ced327a7a3a34dd3c44e543de9244)

Change-Id: I8ff4939634f919f7566b499985af89960fd6ab09
Reviewed-on: https://chromium-review.googlesource.com/954346
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#542861}
Reviewed-on: https://chromium-review.googlesource.com/962831
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#237}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/687e67157b8f44587d76167143bc407066541d33/ash/public/cpp/shelf_types.h
[modify] https://crrev.com/687e67157b8f44587d76167143bc407066541d33/ash/shelf/shelf_background_animator.cc
[modify] https://crrev.com/687e67157b8f44587d76167143bc407066541d33/ash/shelf/shelf_background_animator_unittest.cc
[modify] https://crrev.com/687e67157b8f44587d76167143bc407066541d33/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/687e67157b8f44587d76167143bc407066541d33/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/687e67157b8f44587d76167143bc407066541d33/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/687e67157b8f44587d76167143bc407066541d33/ash/shell.cc
[modify] https://crrev.com/687e67157b8f44587d76167143bc407066541d33/ash/shell.h
[modify] https://crrev.com/687e67157b8f44587d76167143bc407066541d33/ash/shell_observer.h
[modify] https://crrev.com/687e67157b8f44587d76167143bc407066541d33/ash/wm/splitview/split_view_controller.cc
►

Sign in to add a comment