New issue
Advanced search Search tips

Issue 807062 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Task
Team-Security-UX



Sign in to add a comment

Turn on HTTP-Bad experiments in fieldtrial_testing_config.json

Project Member Reported by est...@chromium.org, Jan 29 2018

Issue description

A bunch of tests will need to be updated.
 

Comment 1 by est...@chromium.org, Jan 30 2018

Status: Started (was: Assigned)

Comment 3 by est...@chromium.org, Jan 30 2018

Labels: Hotlist-HttpBad
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b6c18abdf46a3f8ec7461070a4b20be10db89be

commit 1b6c18abdf46a3f8ec7461070a4b20be10db89be
Author: Emily Stark <estark@google.com>
Date: Thu Feb 01 23:14:06 2018

Add HTTP-Bad Phase 3 experiment to field trial testing config

Some browser tests needed to be updated accordingly. I deleted a couple
that were redundant with tests where the field trial is enabled. For a
few others that only made sense in the pre-field trial world, I just
disabled the feature for them, though we'll want to clean them up
eventually after the field trial launches.

Bug:  807062 
Change-Id: I480b2527375368d6146c1ddace2551dece9ec596
Reviewed-on: https://chromium-review.googlesource.com/891677
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533845}
[modify] https://crrev.com/1b6c18abdf46a3f8ec7461070a4b20be10db89be/chrome/browser/ssl/security_state_tab_helper_browsertest.cc
[modify] https://crrev.com/1b6c18abdf46a3f8ec7461070a4b20be10db89be/testing/variations/fieldtrial_testing_config.json

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b79ba3c13236d762227ce0201ee0a4cf83c05c5

commit 5b79ba3c13236d762227ce0201ee0a4cf83c05c5
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Feb 02 14:51:42 2018

Revert "Add HTTP-Bad Phase 3 experiment to field trial testing config"

This reverts commit 1b6c18abdf46a3f8ec7461070a4b20be10db89be.

Reason for revert:
This broke two browser_tests in Official Windows builds:
SecurityStateTabHelperTest.DefaultSecurityLevelOnFilesystemUrl
SecurityStateTabHelperTest.DefaultSecurityLevelOnBlobUrl

Original change's description:
> Add HTTP-Bad Phase 3 experiment to field trial testing config
> 
> Some browser tests needed to be updated accordingly. I deleted a couple
> that were redundant with tests where the field trial is enabled. For a
> few others that only made sense in the pre-field trial world, I just
> disabled the feature for them, though we'll want to clean them up
> eventually after the field trial launches.
> 
> Bug:  807062 
> Change-Id: I480b2527375368d6146c1ddace2551dece9ec596
> Reviewed-on: https://chromium-review.googlesource.com/891677
> Reviewed-by: Eric Lawrence <elawrence@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Commit-Queue: Emily Stark <estark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533845}

TBR=jwd@chromium.org,estark@chromium.org,elawrence@chromium.org

Change-Id: I34688c6ef005ac74e79d78a5b8d451790dba96a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  807062 ,  808424 
Reviewed-on: https://chromium-review.googlesource.com/899150
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534048}
[modify] https://crrev.com/5b79ba3c13236d762227ce0201ee0a4cf83c05c5/chrome/browser/ssl/security_state_tab_helper_browsertest.cc
[modify] https://crrev.com/5b79ba3c13236d762227ce0201ee0a4cf83c05c5/testing/variations/fieldtrial_testing_config.json

Status: Assigned (was: Fixed)
Oops, sorry my review failed to point out that the field_trial_testing_config.json only applies to a subset of the bots. Pretty sure I broke the build the same way in HB1.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1b3c560ca1f4dfb3ce74911b6cdc7e32254cc23

commit e1b3c560ca1f4dfb3ce74911b6cdc7e32254cc23
Author: Emily Stark <estark@google.com>
Date: Sun Feb 04 01:30:27 2018

Reland "Add HTTP-Bad Phase 3 experiment to field trial testing config"

This is a reland of 1b6c18abdf46a3f8ec7461070a4b20be10db89be.

Enabled feature in tests that were failing on official builders.

Original change's description:
> Add HTTP-Bad Phase 3 experiment to field trial testing config
>
> Some browser tests needed to be updated accordingly. I deleted a couple
> that were redundant with tests where the field trial is enabled. For a
> few others that only made sense in the pre-field trial world, I just
> disabled the feature for them, though we'll want to clean them up
> eventually after the field trial launches.
>
> Bug:  807062 
> Change-Id: I480b2527375368d6146c1ddace2551dece9ec596
> Reviewed-on: https://chromium-review.googlesource.com/891677
> Reviewed-by: Eric Lawrence <elawrence@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Commit-Queue: Emily Stark <estark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533845}

Bug:  807062 
Change-Id: If98c8d6a80b0975f37f83febad7fbbdb8a2cd7ac
TBR: jwd@chromium.org,elawrence@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/900364
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534287}
[modify] https://crrev.com/e1b3c560ca1f4dfb3ce74911b6cdc7e32254cc23/chrome/browser/ssl/security_state_tab_helper_browsertest.cc
[modify] https://crrev.com/e1b3c560ca1f4dfb3ce74911b6cdc7e32254cc23/testing/variations/fieldtrial_testing_config.json

Status: Fixed (was: Assigned)

Sign in to add a comment