New issue
Advanced search Search tips

Issue 807041 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Participants' hotlists:
Launcher-Polish


Sign in to add a comment

app launcher doesn't use "omnibox" chrome app api well

Project Member Reported by elijahtaylor@chromium.org, Jan 29 2018

Issue description

Chrome Version: 64.0.3282.87
OS: ChromeOS

What steps will reproduce the problem?
(1) install secure shell: https://chrome.google.com/webstore/detail/secure-shell/pnhechapfaindjhompbnflcldabbghjo
(2) open launcher
(3) type 'ssh '

What is the expected result?

(a) autocomplete would kick in and return valid results from the omnibox integration in the app

(b) clicking on the result or pressing enter on the "ssh username@hostname" suggestion would do something useful, right now it is an error page if no ssh user/host are typed in, and a web navigation to the hostname if a user/host pair are typed (maybe a bug in secure shell:  issue 807039 )

What happens instead?

no autocomplete suggestions are listed, and navigation to the app from these results are bad
 

Comment 1 by vapier@chromium.org, Jan 29 2018

 Issue 807039  has been merged into this issue.

Comment 2 by vapier@chromium.org, Jan 29 2018

Cc: vapier@chromium.org
Labels: OS-Chrome
i posted some debug details to  issue 807039  ... it looks like a bug in the app launcher code to me in that it doesn't properly implement the omnibox api
Cc: newcomer@chromium.org
Owner: omrilio@chromium.org
Omri, what do you think? 
Cc: shibasheikh@chromium.org
I'd love to support this, but I think we should first support inline auto-complete which is kind of a prerequisit for this.
+Shiba who was also interested in inline auto-complete.
Components: UI>Shell>Launcher
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Owner: shibasheikh@chromium.org
The inline autocomplete mentioned in #4 has recently landed in ToT M71. Shall we revisit this issue?
We have autocomplete now? Isn't it on by default?
Owner: omrilio@chromium.org
to omri for followup.

Sign in to add a comment