New issue
Advanced search Search tips

Issue 807039 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 807041
Owner: ----
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

nassh: app launcher integration with "omnibox" API does not work

Project Member Reported by elijahtaylor@chromium.org, Jan 29 2018

Issue description

Chrome Version: 64.0.3282.87
OS: Chrome OS

What steps will reproduce the problem?
(1) install secure shell
(2) open app launcher
(3) type "ssh"
(4) click "ssh user@hostname[:port]" suggestion

alternate steps to reproduce different problem:
(3b) type "ssh <user>@<host>", press enter

What is the expected result?

something useful would happen: for empty query, maybe a connection selector.  For filled out user/host, a connection would start

What happens instead?

(a) empty query shows an error page

(b) user/host entry navigates to the host as a web URL



 
note there is a related bug in that app launcher integration doesn't work for autocomplete for the "omnibox" api, maybe this needs to be sorted out in the launcher mostly: issue 807041

Comment 2 by vapier@chromium.org, Jan 29 2018

Mergedinto: 807041
Status: Duplicate (was: Untriaged)
Summary: nassh: app launcher integration with "omnibox" API does not work (was: secure shell: app launcher integration with "omnibox" API does not work)
i don't think this is anything i have control over.  if you look at the URL it takes you to:
  chrome-extension://pnhechapfaindjhompbnflcldabbghjo/?q={searchTerms}

that {searchTerms} should have been expanded by the caller, and Secure Shell never sends to the root page.  the onInputEntered event starts off with:
  var url = chrome.runtime.getURL('html/nassh.html#' + text);

so the fact that there's no "nassh.html" in there makes me believe the app launcher never called us and just blindly does its own thing.

i'm going to mark this as a dupe of issue 807041 until there's a reason to believe there's anything on our side we're doing wrong.

Sign in to add a comment