New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807008 link

Starred by 4 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on: View detail
issue 809368
issue 835762

Blocking:
issue 545318



Sign in to add a comment

[css-typed-om] Update style map IDLs

Project Member Reported by shend@chromium.org, Jan 29 2018

Issue description

Should move:
- CSSStyleRule.attributeStyleMap -> CSSStyleRule.styleMap
- Element.attributeStyleMap -> ElementCSSInlineStyle.attributeStyleMap (should not affect any existing code)

Spec: https://github.com/w3c/css-houdini-drafts/issues/572
 
Cc: -hs1217....@samsung.com
Owner: hs1217....@samsung.com
Status: Assigned (was: Available)
i will take this issue.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4f8b21412f49d28290744cc66f4a743f18ddacb

commit f4f8b21412f49d28290744cc66f4a743f18ddacb
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Tue Jan 30 23:25:49 2018

[css-typed-om] rename attributeStyleMap to styleMap at CSSStyleRule

rename attributeStyleMap to styleMap at CSSStyleRule

https://github.com/w3c/css-houdini-drafts/issues/572
https://github.com/w3c/css-houdini-drafts/pull/596

Bug: 807008
Change-Id: I8e5f140914783c074f73f75ed94312989e90e0ef
Reviewed-on: https://chromium-review.googlesource.com/893239
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#533077}
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/resources/testhelper.js
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/declared.tentative.html
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/test.tentative.html
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/interface-expected.txt
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/interface.html
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/LayoutTests/typedcssom/resources/testhelper.js
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/declared/delete-rule-crash.html
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/Source/core/css/CSSStyleRule.cpp
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/Source/core/css/CSSStyleRule.h
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/Source/core/css/CSSStyleRule.idl
[modify] https://crrev.com/f4f8b21412f49d28290744cc66f4a743f18ddacb/third_party/WebKit/Source/core/css/cssom/DeclaredStylePropertyMap.h

Blockedon: 809368

Comment 6 by shend@chromium.org, Feb 14 2018

Oops, sorry I didn't see this. Yep, this sounds good (I didn't know ElementCSSInlineStyle isn't implemented in Blink).
Blockedon: 835762

Sign in to add a comment