[css-typed-om] Throw RangeError on division by zero. |
|||
Issue descriptionWhen we invert a CSSUnitValue with 0 value, we should throw a RangeError. Spec: https://github.com/w3c/css-houdini-drafts/issues/575
,
Jan 30 2018
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31917746feba0dc59166c80a8534e22146fa59cf commit 31917746feba0dc59166c80a8534e22146fa59cf Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Sat Feb 03 07:15:57 2018 [css-typed-om] throw RangeError when divide-by-zero when we invert a CSSUnitValue with 0 value, we should throw a RangeError. present, we are used std::transform to get inverted values. when some values makes RangeError in a loop, we don't need to calcuate remaining values which not inverted. Bug: 807006 Change-Id: I443bb032e29b0ad0f8bbb872ae9bfdc5877255f6 Reviewed-on: https://chromium-review.googlesource.com/893020 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#534264} [modify] https://crrev.com/31917746feba0dc59166c80a8534e22146fa59cf/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/numeric-objects/arithmetic.tentative.html [modify] https://crrev.com/31917746feba0dc59166c80a8534e22146fa59cf/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.cpp [modify] https://crrev.com/31917746feba0dc59166c80a8534e22146fa59cf/third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp
,
Feb 3 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by hs1217....@samsung.com
, Jan 30 2018Owner: hs1217....@samsung.com
Status: Assigned (was: Available)