Remove close-x button on all modal dialogs in Chrome WebUI |
||||||||
Issue descriptionToday -------------- Every dialog in webui today is modal, meaning that it cannot be dismissed by clicking out, forcing the user to take an action on the dialog, i.e. [OK GOT IT] [CANCEL] Every dialog in webui today *should have* both an affirmative (OK GOT IT) and negative action (CANCEL). Expected -------------- Remove the close-x button on all modal dialogs in chrome webUI Redundant: The close-x button is redundant to any negative action presented in a modal dialog (CANCEL). Consistent: The close-x button will not be present in any modal dialog presented in Chrome's secondary UI, via Harmony.
,
Apr 12 2018
,
May 11 2018
,
May 12 2018
,
May 14 2018
,
May 14 2018
namratakannan@: Is this ready to be worked on? I'm going to review the cr-dialog usage and note where we're missing a cancel/close/OK button. Do we need to keep the 'X' close button for print preview?
,
May 15 2018
,
May 15 2018
I talked with namratakannan@. We're keeping the 'X' close button for print preview dialogs. And the print preview dialogs should not included the style refresh, 832179.
,
May 16 2018
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf4d5c8bc6dbe29c40de0fb996b33261ee485f5a commit bf4d5c8bc6dbe29c40de0fb996b33261ee485f5a Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed May 16 23:26:22 2018 WebUI: removing X close button for most instances of cr-dialog Bug: 806990 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I88014d77169c3b6f75c5905fa4219b8be92e6fa4 Reviewed-on: https://chromium-review.googlesource.com/1060265 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#559330} [modify] https://crrev.com/bf4d5c8bc6dbe29c40de0fb996b33261ee485f5a/chrome/browser/resources/md_extensions/options_dialog.html [modify] https://crrev.com/bf4d5c8bc6dbe29c40de0fb996b33261ee485f5a/chrome/browser/resources/md_user_manager/error_dialog.html [modify] https://crrev.com/bf4d5c8bc6dbe29c40de0fb996b33261ee485f5a/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html [modify] https://crrev.com/bf4d5c8bc6dbe29c40de0fb996b33261ee485f5a/chrome/browser/resources/print_preview/new/destination_dialog.html [modify] https://crrev.com/bf4d5c8bc6dbe29c40de0fb996b33261ee485f5a/chrome/browser/resources/print_preview/new/provisional_destination_resolver.html [modify] https://crrev.com/bf4d5c8bc6dbe29c40de0fb996b33261ee485f5a/chrome/test/data/webui/cr_elements/cr_dialog_test.js [modify] https://crrev.com/bf4d5c8bc6dbe29c40de0fb996b33261ee485f5a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/bf4d5c8bc6dbe29c40de0fb996b33261ee485f5a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
,
May 22 2018
Changing milestone, since this made it to M68. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dpa...@chromium.org
, Feb 6 2018Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)