New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 806988 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug
Hotlist-MemoryInfra



Sign in to add a comment

MemoryTracingBrowserTest.TestMemoryInfra is flaky due to excessive output

Project Member Reported by bsep@chromium.org, Jan 29 2018

Issue description

MemoryTracingBrowserTest.TestMemoryInfra passes but is marked as failing on the Linux Chromium OS ASan LSan bot, because it's producing too much output. I will disable the test.

From logs:
SUMMARY: AddressSanitizer: 226605 byte(s) leaked in 1201 allocation(s).
-----------------------------------------------------
Suppressions used:
  count      bytes template
      2        288 libfontconfig
-----------------------------------------------------
[9747:9747:0129/101639.184518:INFO:chrome_cryptauth_service.cc(239)] Refresh token not yet available; waiting before starting CryptAuth managers.
[9747:9747:0129/101639.322598:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[9747:9747:0129/101639.322682:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[       OK ] MemoryTracingBrowserTest.TestMemoryInfra (11204 ms)
[841/841] MemoryTracingBrowserTest.TestMemoryInfra (12070 ms)
1 test produced excessive output:
    MemoryTracingBrowserTest.TestMemoryInfra (../../chrome/test/base/memory_tracing_browsertest.cc:117)

Example failures:
https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/25920
https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/25919
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a41efa9e490b2fdeb40339daef6d1fe2a217e439

commit a41efa9e490b2fdeb40339daef6d1fe2a217e439
Author: Bret Sepulveda <bsep@chromium.org>
Date: Mon Jan 29 21:47:15 2018

Disable flaky MemoryTracingBrowserTest.TestMemoryInfra.

The test is failing due to excessive output.

TBR=ssid@chromium.org

Bug: 806988
Change-Id: Iaf311c39049405bdad1e461391b86055f5baf80d
Reviewed-on: https://chromium-review.googlesource.com/891699
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532600}
[modify] https://crrev.com/a41efa9e490b2fdeb40339daef6d1fe2a217e439/chrome/test/base/memory_tracing_browsertest.cc

Cc: linds...@chromium.org
@ssid@ can you PTAL at this disable for the loss of test coverage?

Comment 3 by ssid@chromium.org, Feb 14 2018

Cc: bsep@chromium.org
Is it ok to disable only on lsan bots using "#if defined(LEAK_SANITIZER)" ?
The output is because of leak stack traces. The test should not output much without lsan enabled.

Comment 4 by bsep@chromium.org, Feb 14 2018

It should be okay. I only saw it on that one bot when I was sheriff.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffd709bfcc3e5c1d1a698d02cc021a15c9dcd52b

commit ffd709bfcc3e5c1d1a698d02cc021a15c9dcd52b
Author: Siddhartha <ssid@chromium.org>
Date: Sat Feb 17 01:28:52 2018

Disable MemoryTracingBrowserTest.TestMemoryInfra only on lsan bots

The test produces too much output due to leaks in html parser.
https://crbug.com/804853

BUG=806988
TBR=bsep@chromium.org

Change-Id: I12b45a16bd25e320021dc495e6031924ba1ac3a5
Reviewed-on: https://chromium-review.googlesource.com/924462
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537497}
[modify] https://crrev.com/ffd709bfcc3e5c1d1a698d02cc021a15c9dcd52b/chrome/test/base/memory_tracing_browsertest.cc

Labels: Hotlist-DisableReview
@ssid@ can you PTAL at this disable for the loss of test coverage?

Sign in to add a comment