local tryjob run doesn't apply given local patch |
||||
Issue descriptionI run '/chromiumos/chromite$ cros tryjob --local --buildroot ~/test/root/ -p chromiumos/chromite:local-branch binhost-pre-cq" The local tryjob doesn't apply the local branch in PreCQSync stage ************************************************************ ** Start Stage PreCQSync - Mon, 29 Jan 2018 11:30:47 -0800 (PST) ** ** Sync and apply patches to test if they compile. ************************************************************ Preconditions for the stage successfully met. Beginning to execute stage... BUILDROOT: /usr/local/google/home/nxia/test/root/repository TRACKING BRANCH: master NEXT MANIFEST: default.xml ... <project name="toolchain/gcc" path="src/aosp/toolchain/gcc" remote="aosp" revision="deec799746e92ab0487eca489499ade08a2610bf"/> <project name="weave/libweave" path="src/weave/libweave" revision="fa29d8f43a37aaf4b47fd2f3c76785050d075a7d" upstream="refs/heads/master"/> <repo-hooks enabled-list="pre-upload" in-project="chromiumos/repohooks"/> </manifest> ************************************************************ ** Finished Stage PreCQSync - Mon, 29 Jan 2018 11:31:36 -0800 (PST) ************************************************************
,
Jan 29 2018
1) didn't try the remote patch. This is a local test branch so didn't upload it to remote. I want to test a patch which is based on another patch, testing it with remote branch gave an error saying that the first patch isn't marked as +2 CR, so it failed to apply the second patch. So I created a local test branch to merge the two patches into one to test them locally. 2) yes.
,
Jan 29 2018
+2 shouldn't be required, but I'm not surprised that you got the error. I'll try to figure it out. Is this a huge blocker?
,
Jan 29 2018
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/pre_cq/builds/79211 gives the error. It'll be good to be able to test changes locally as before, not a huge blocker.
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/033ed909d5f367f33397e80294d11b6115c21170 commit 033ed909d5f367f33397e80294d11b6115c21170 Author: Daniel Erat <derat@chromium.org> Date: Fri Feb 02 02:08:49 2018 chromite: Add --help warning about cros tryjob -p bugginess. Warn people away from using cros tryjob's -p flag. BUG=chromium:806963,chromium:807834 TEST=manual: ran "cros tryjob --help" and saw warning Change-Id: I2d56d2e53dae57433a42acb6e94766623d37a80a Reviewed-on: https://chromium-review.googlesource.com/896963 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Jacob Kopczynski <jkop@chromium.org> [modify] https://crrev.com/033ed909d5f367f33397e80294d11b6115c21170/cli/cros/cros_tryjob.py
,
Mar 19 2018
At least it's documented now. We have a ton of weird bugs with local CLs. Preliminary proposals have been discussed, but not prioritized.
,
Apr 12 2018
,
Jun 8 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dgarr...@chromium.org
, Jan 29 2018