Tryjobs checkboxes get checked when changing search filter |
||||
Issue descriptionAffected Version: 2.15-rc2-2157-g1438975847 What steps will reproduce the problem? 1. Click "Choose Tryjobs" on a CL 2. Type a filter, e.g. "mac_chromium" 3. Check a checkbox, let's say mac_chromium_10.10 4. Backspace in the filter textbox until more bots show in results Expected: The checked bot stays checked; no other bots are checked. Actual: Bots in other sections become checked, e.g. "mac_angle_compile_dbg_ng.
,
Jan 29 2018
WOAH That's... magic. I just reproduced this behavior. Thanks for reporting. I have no idea how this is happening.
,
Jan 29 2018
,
Jan 29 2018
,
Jan 29 2018
sorry, it's hard to figure out when a chromium review bug is a gerrit or chromium issue!
,
Jan 29 2018
No problem, don't worry about it. You used the "Send Feedback" button which was absolutely the right thing to do, given that the problem was in the UI. This is what triage processes are for :)
,
Jan 30 2018
Ok so the good news is that the build isn't *actually* selected. (This can be seen by following the reproduction steps above, then typing and deleting a single character. This causes all the erroneously-selected checkboxes to become correctly unchecked.) So this bug won't cause a bunch of extra bots to run. It's still confusing as heck, and I'm not entirely sure how it works (some sort of race between repopulating the list of builders after the filter changes, and computing which builders are selected...).
,
Jan 30 2018
nested dom-repeats can be painful. try changing their items to two-way bindings and see if the list is repopulated correctly? (That shouldn't make a difference, but I recall encountering situations where it did.)
,
Mar 14 2018
Issue 821104 has been merged into this issue.
,
Aug 10
Unassigning from myself because I'm on sabbatical. |
||||
►
Sign in to add a comment |
||||
Comment 1 by david.os...@gmail.com
, Jan 28 2018