//testing/gmock is depending on //base |
|
Issue descriptionIn https://chromium-review.googlesource.com/c/chromium/src/+/848466, //testing/gmock started to depend on //testing/gmock:gmock_mutant which depends on //base. The problem with this dependency chain is that //base use C++14 code, while //testing/gmock is used also by third_party projects that are not yet using C++14 (e.g. WebRTC which is still using C++11). This bug tracks the solution of this problem in the long term. For now a fix has been added in https://chromium-review.googlesource.com/c/chromium/src/+/888698. The fix includes gmock_mutant only if build_with_chromium is True.
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5467fc863fa724e565805687452ac938f6f2145 commit f5467fc863fa724e565805687452ac938f6f2145 Author: Mirko Bonadei <mbonadei@chromium.org> Date: Mon Jan 29 22:23:15 2018 Depend on gmock_mutant only when building Chromium. //testing:gmock_mutant depends on //base (which uses C++14) and this breaks the WebRTC build (which is pinning C++11). The dependency has been introduced with: https://chromium-review.googlesource.com/c/chromium/src/+/848466 The easiest fix is to pull //testing:gmock_mutant in //testing/gmock only when building with Chromium. Bug: 806952 Change-Id: I1137dbb7dcb404a613dc9a37bb51d2b6c941c793 Reviewed-on: https://chromium-review.googlesource.com/888698 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#532625} [modify] https://crrev.com/f5467fc863fa724e565805687452ac938f6f2145/testing/gmock/BUILD.gn |
|
►
Sign in to add a comment |
|
Comment 1 by mbonadei@chromium.org
, Jan 29 2018