MessagingApiTest regression with UserActivationV2 |
||||
Issue descriptionWith --enable-features=UserActivationV2, MessagingApiTest.MessagingUserGesture fails at the following assumption: https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_messages_apitest.cc?rcl=2de306f7baa7c4d00ae4c0e4b06e3426e54e8670&l=1245 Not clear why this is happening. The only possible cause that comes to my mind is that user gesture (or activation) is perhaps not reaching the correct Frame.
,
Feb 7 2018
Looks like the failure is caused by a null frame pointer here: https://cs.chromium.org/chromium/src/extensions/renderer/messaging_util.cc?rcl=31bbb8b1f07bcc51d64ff6c8913dc1ef48493c0f&l=114 I will send a fix for review tomorrow.
,
Feb 8 2018
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b61d034fb4dbfdb7fe03389395446ffadf28aeb commit 7b61d034fb4dbfdb7fe03389395446ffadf28aeb Author: Mustaq Ahmed <mustaq@google.com> Date: Wed Feb 14 21:59:08 2018 [Extensions] Fix user gesture indication for extension messaging blink::WebUserGestureIndicator::IsProcessingUserGesture() expects a WebFrame associated when looking for if a user gesture is being processed with UserActivationV2. This CL Updates messaging_util to pass in the current frame when constructing an extension message. Bug: 806938 Change-Id: I748f78c6a2e2ec440cf4a156350e8197c8490fb3 Reviewed-on: https://chromium-review.googlesource.com/907648 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#536835} [modify] https://crrev.com/7b61d034fb4dbfdb7fe03389395446ffadf28aeb/extensions/renderer/messaging_bindings.cc [modify] https://crrev.com/7b61d034fb4dbfdb7fe03389395446ffadf28aeb/extensions/renderer/messaging_util.cc [modify] https://crrev.com/7b61d034fb4dbfdb7fe03389395446ffadf28aeb/extensions/renderer/messaging_util.h
,
Feb 15 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mustaq@chromium.org
, Jan 29 2018