New issue
Advanced search Search tips

Issue 806936 link

Starred by 1 user
Status: Fixed
Owner:
kylixrd@chromium.org
Closed: Jul 11
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Widget::SetBoundsConstrained() doesn't actually constrain the requested bounds to the screen bounds.

Project Member Reported by kylixrd@chromium.org, Jan 29 2018 
OS: Windows, Linux, ChromeOS

Screen Bounds: 0, 0, 500, 500

widget->SetBoundsConstrained(gfx::Rect(480, 10, 100, 30));

Expected widget bounds: 390, 10, 100, 30
Actual widget bounds: 480, 10, 100, 30
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97f6a33f764f4047398baa69cb1a9654dc4002c0

commit 97f6a33f764f4047398baa69cb1a9654dc4002c0
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue Apr 17 14:59:58 2018

Fix Widget::SetBoundsConstrained

Proposal: https://docs.google.com/document/d/1KrKEWSK64es3W3LYKQUpvwMzUJqTz8owFGXuJQqeXzs/edit?usp=sharing

Bug:  806936 
Change-Id: Id086f9835a710cf2165f4ba8bd07904229301b67
Reviewed-on: https://chromium-review.googlesource.com/946554
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551337}
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ash/components/shortcut_viewer/DEPS
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ash/components/shortcut_viewer/views/keyboard_shortcut_view_unittest.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ash/display/screen_position_controller.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ash/root_window_controller.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ash/wm/window_properties.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ash/wm/window_properties.h
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/BUILD.gn
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/widget/desktop_aura/desktop_native_widget_aura.h
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/widget/desktop_widget_unittest.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/widget/native_widget_aura.h
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/widget/native_widget_mac.h
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/widget/native_widget_mac.mm
[add] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/widget/native_widget_private.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/widget/native_widget_private.h
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/widget/widget.cc
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/views/widget/widget.h
[modify] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/wm/BUILD.gn
[add] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/wm/core/window_properties.cc
[add] https://crrev.com/97f6a33f764f4047398baa69cb1a9654dc4002c0/ui/wm/core/window_properties.h

Comment 2 by kylixrd@chromium.org, Jul 11

Owner: kylixrd@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment